-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cargo workspaces #3602
Support cargo workspaces #3602
Conversation
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
cf19fce
to
8415ed7
Compare
Reference: #3598 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
8415ed7
to
2a2f512
Compare
cf8209b
to
bf60f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyanSinhaMahapatra Looks good to me, I left a comment about adding a newline
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
bf60f70
to
ff84e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.... with a nit wrt. using "workspace" as a placeholder value?
Could we use something better, may be using extra data instead for fields that should be copied back from the workspace in a lower package?
Also would the top level workspace exist as a package of its own or not?
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Yeah this is much better and correct, doing this now.
So I did consider doing this, but the top-level workspace usually does not have any purl fields there, only some extra data wrt source/licenses, see https://github.com/nexB/scancode-toolkit/blob/support-cargo-workspaces/tests/packagedcode/data/cargo/cargo-with-workspace/Cargo.toml#L12 for example. So for now we are not adding top-level packages here, but we can revisit this if we get better examples. But if there are other manifests of other flavours, we'll be adding packages for those. |
28aeebe
to
50d2afe
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
8524736
to
d626332
Compare
I've removed the improved package assembly part from this PR and pushed this as a separate branch at: https://github.com/nexB/scancode-toolkit/tree/update-package-assembly, since this was not ready to merge. Otherwise this was reviewed and approved, so merging! |
Fixes #3598
Tasks
Run tests locally to check for errors.