Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new license detection rules #3575

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Add new license detection rules #3575

merged 7 commits into from
Nov 9, 2023

Conversation

pombredanne
Copy link
Contributor

@pombredanne pombredanne commented Nov 9, 2023

These are misc. rules to improve detection, mostly for Maven edge cases.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Copy link
Contributor

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Merging this.

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 1c4d6be into develop Nov 9, 2023
34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the more-licenses branch November 9, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants