npm: support aliases in yarn lock v1 #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a `yarn.lock v1` file, ScanCode does not handle aliases properly. Aliases have the form: `<alias-package>@npm:<package>` More info about aliases: https://classic.yarnpkg.com/lang/en/docs/cli/add/#toc-yarn-add-alias The current code incorrecly parse aliases and end up throwing an exception, resulting in empty results. A single alias in a yarn.lock file is gonna make the parser return 0 packages. This patch adds the logic to handle them by simply dropping the alias part, and just keeping the package part. Test plan: updated the unit tests. Signed-off-by: Adrien Schildknecht <[email protected]>
An assert in the code was making aliases using `@` fail. Signed-off-by: Adrien Schildknecht <[email protected]>
|
@schischi do you know if these aliases also show up in yarn v2? |
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Apr 26, 2024
Reference: #3555 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
|
@pombredanne it does not seem like we have this in yarn v2 as there is no mention of aliases in the doc for yarn v2 at https://yarnpkg.com/cli/add similar to https://classic.yarnpkg.com/lang/en/docs/cli/add/#toc-yarn-add-alias, which is the doc for yarn v1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanCode does not handle aliases in
yarn.lock v1file.Aliases have the form:
<alias-package>@npm:<package>More info about aliases: https://classic.yarnpkg.com/lang/en/docs/cli/add/#toc-yarn-add-alias
The current code incorrectly parses aliases and end up throwing an exception, resulting in empty results.
A single alias in a yarn.lock file is gonna make the parser return 0 packages.
This patch adds the logic to handle them by simply dropping the alias part, and just keeping the package part.
Test plan: updated the unit tests.
Signed-off-by: Adrien Schildknecht [email protected]