Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update misc detections #3462

Merged
merged 12 commits into from
Aug 3, 2023
Merged

Update misc detections #3462

merged 12 commits into from
Aug 3, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jul 20, 2023 •
edited
Loading

Reference:

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra
Also handle .jar archives which don't have a type
2d9f4ba 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Add new epl-1.0 and other-copyleft rule
b1ad02f 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Add new license rule model attributes
0988c72 
To the license Rule class:

- Adds is_license_clue attribute
- Adds is_deprecated attribute

Also implements related processing.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-maven-detections branch from 84831f3 to 0988c72 Compare July 20, 2023 14:13
@AyanSinhaMahapatra
Fix unknown license clues bug
edd7974 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Update rules to be license clues
951b155 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Fix setup.cfg license detection bug
79871d3 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-maven-detections branch 2 times, most recently from 924395d to 74bc574 Compare July 21, 2023 18:19
@AyanSinhaMahapatra
Fix license detection bugs
cfa072b 
* Top level packages were inconsistant because of license plugin post
  processing running after the package plugin post processing.

* Adjust license clues/false-postives/bad matches heuristics.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-maven-detections branch from 74bc574 to cfa072b Compare July 21, 2023 18:23
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Update maven license detections Update maven detections Jul 21, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Update maven detections Update misc detections Jul 21, 2023
@AyanSinhaMahapatra
Add rules and tests from jquery-form
35d8f6b 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-maven-detections branch from 7ee80d2 to 35d8f6b Compare July 21, 2023 21:02
pombredanne
pombredanne requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM overall, with some nits and questions for your consideration!

src/licensedcode/models.py Outdated Show resolved Hide resolved
src/licensedcode/models.py Outdated Show resolved Hide resolved
src/packagedcode/pypi.py Show resolved Hide resolved
src/summarycode/score.py Show resolved Hide resolved
src/summarycode/todo.py Outdated Show resolved Hide resolved
src/licensedcode/data/rules/agpl-3.0-plus_or_commercial-license_7.RULE Show resolved Hide resolved
src/licensedcode/data/rules/mit_or_gpl-2.0_68.RULE Show resolved Hide resolved
src/licensedcode/detection.py Outdated Show resolved Hide resolved
AyanSinhaMahapatra added a commit that referenced this pull request Jul 24, 2023
@AyanSinhaMahapatra
Address feedback on #3462
8697b3f 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

@pombredanne addressed feedback and all green now!

@AyanSinhaMahapatra
Address feedback on #3462
5f458b9 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-maven-detections branch from 8697b3f to 5f458b9 Compare July 24, 2023 18:34
@AyanSinhaMahapatra
Make license rule a clue
06f20bd 
Reference: #3480
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 5dfcfcb into develop Aug 3, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-maven-detections branch August 3, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne