Fix misc license detection related bugs #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in LicenseDetection identifier where we were only returning UUID as identifier, and without the license-expression in the case where a detection is modified and we are calculating a new identifier. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Fixing a bug in scancode_version where we were not returning unannotated tags, but we should always return the latest tag here. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-follow-up
branch
from
4f5ed6d to
1fa4668
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-follow-up
branch
from
cf08f4b to
30be519
Compare
AyanSinhaMahapatra
changed the title
JonoYang
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
@AyanSinhaMahapatra LGTM! You'll want to update this test file before merging: https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=10398&view=logs&j=e968ac97-6fe5-5e03-7848-d38fdbd63e89&t=68b960ee-accc-5f66-8291-47be569f7afb&l=8610
AyanSinhaMahapatra
force-pushed
the
license-detection-follow-up
branch
from
8d388fe to
bbec4af
Compare
Since there are multiple possible license keys in a license detection, and each license policy is for a license key, the license_policy attribute should be a list, and this modifies the attribute from dict to list. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
license-detection-follow-up
branch
from
bbec4af to
5c9d5a8
Compare
|
@JonoYang @pombredanne thanks! Fixed the tests, now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unannotated tags, but we should always return the latest tag here.
Tasks
Run tests locally to check for errors.