Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HERE Proprietary rule for pom.xml files #3212

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Add HERE Proprietary rule for pom.xml files #3212

merged 2 commits into from
Jan 21, 2023

Conversation

bennati
Copy link
Contributor

@bennati bennati commented Jan 20, 2023 •
edited by pombredanne
Loading

Signed-off-by: Bennati, Stefano [email protected]

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne
pombredanne approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pombredanne
Require key phrase
b8d0b57 
This avoids any ambiguity with other rules.

Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
pombredanne reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this refinement b8d0b57 that avoids any ambiguity with other rules. (We need to improve these POM-related rules alright anyway).

@pombredanne
Copy link
Contributor

Thanks! merging

@pombredanne pombredanne merged commit cad392f into aboutcode-org:develop Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennati @pombredanne