Fix issue 3155 by running scancode-reindex-licenses subcommand instead of using --reindex-licenses flag
#3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script provides a CLI entry point for the `scancode-reindex- licenses` subcommand introduced by 5361052. Signed-off-by: Abhishek Kumar <[email protected]>
The `--reindex-licenses` flag has been removed from the main `scancode` executable into the separate subcommand `scancode-reindex-licenses`. Signed-off-by: Abhishek Kumar <[email protected]>
As reindexing licenses is an exceptional operation, a separate script is not preferable. Hence, the script has been removed. In the earlier Dockerfile, `./scancode --reindex-licenses` did two jobs: 1. The initial configuration 2. Reindexing of licenses In the new Dockerfile, `./configure` is first run to configure the venv. This is followed by a run of `scancode-reindex-licenses`. Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
s01ipsist
reviewed
Nov 23, 2022
Dockerfile best practice is to combine successive RUN commands so as to minimise image layers. Signed-off-by: Abhishek Kumar <[email protected]>
The test should ensure that scancode-toolkit is capable of being built successfully using Docker. Additionally, the built script should run successfully. Signed-off-by: Abhishek Kumar <[email protected]>
s01ipsist
reviewed
Nov 24, 2022
There was a problem hiding this comment.
Looks ok to me @abhi-kr-2100 but we need a project maintainer to review
|
Thanks for taking the time to review this @s01ipsist. Let me gently ping @pombredanne. |
pombredanne
approved these changes
Nov 24, 2022
|
@abhi-kr-2100 Thanks! |
|
@abhi-kr-2100 I did not pay attention to the details, but your changes have disabled the Azure pipelines entirely. I am going to revert this urgently |
|
@pombredanne Oops. Please do the needful. |
pombredanne
added a commit
that referenced
this pull request
Nov 29, 2022
This was mistakenly disabled with #3159 Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3155
This PR only modifies the Dockerfile. In the erroneous Dockerfile,
./scancode --reindex-licenseswas used toSince the
--reindex-licensesflag has been removed, this led to an error. The fix is to use the new subcommandscancode-reindex-licensesto do the reindexing. Configuration is done prior to the reindexing using the./configurescript.Tasks
Run tests locally to check for errors.
Signed-off-by: Abhishek Kumar [email protected]