Separate Package parsing functions #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We would like to have a way to get PackageData objects from different manifest data without using generator from the DatafileHandler.parse() method
* Update get_urls for several packages to accept arbitrary keyword arguments
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Update CHANGELOG.rst Signed-off-by: Jono Yang <[email protected]>
pombredanne
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some code in packagecode for use outside of scancode toolkit. Currently, our package handlers return a generator of PackageData objects when we parse a manifest file. I would like to use the code to get the package object itself, rather than the generator. I've updated the code for the freebsd, haxe, maven, and npm parsers such that the parse method functionality is separated: the parse function for the freebsd, haxe, maven, and npm parsers now yields from another function named
_parse, which returns a single PackageData object for a given manifest.