Add new and improved licenses and licenses rules #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some spurrious AGPL and GPL were messging up detection. Reported-by: John M. Horan <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is fixing failing tests following new rules added for #1418 and #1419 Reported-by: John M. Horan <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
commented
Mar 6, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1421 +/- ##
===========================================
+ Coverage 83.65% 84.48% +0.82%
===========================================
Files 119 119
Lines 13949 14794 +845
===========================================
+ Hits 11669 12498 +829
- Misses 2280 2296 +16
Continue to review full report at Codecov.
|
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
new-and-improved-license-rules-03-06
branch
from
8590d07 to
5d2b418
Compare
* use None for attribute defaults NOT an empty string * perform all validations in validate() * add validate() tests Signed-off-by: Philippe Ombredanne <[email protected]>
Both are duplicates and mit-old-style-no-advert has more known uses Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Several tests are not useful since they check an exact match and are bringing nothing new. We just kept a few and removed the other ones. A hash match test is kinda tautological and does not excercise anything in the license matching algorithms. Even if runs fast it still runs for nothing. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This was deleted by mistake Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Member
Author
|
All greenish 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an "omnibus" PR for miscellaneous new licenses and license detection rules.