SCTK Fails to Detect "New Relic Software License v1.0" in license scan

[chinyeungli]

Following are the detection result.

"license_expression": "unknown-spdx OR unknown-spdx OR unknown-spdx",
"license_expression_spdx": "LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx",
"from_file": "code/security-agent-2.0.0.tgz-extract/package/index.js",
"start_line": 3,
"end_line": 3,
"matcher": "1-spdx-id",
"score": 100,
"matched_length": 6,
"match_coverage": 100,
"rule_relevance": 100,
"rule_identifier": "spdx-license-identifier-unknown_spdx_or_unknown_spdx_or_unknown_spdx-ce7ce64888134e098b3fda1808ef247a044fd625",
"rule_url": null,
"matched_text": " * SPDX-License-Identifier: New Relic Pre-Release",
"matched_text_diagnostics": "SPDX-License-Identifier: New Relic Pre-Release"

"license_expression": "unknown-license-reference",
"license_expression_spdx": "LicenseRef-scancode-unknown-license-reference",
"from_file": "code/newrelic-12.5.1.tgz-extract/package/README.md",
"start_line": 274,
"end_line": 274,
"matcher": "2-aho",
"score": 100,
"matched_length": 3,
"match_coverage": 100,
"rule_relevance": 100,
"rule_identifier": "license-intro_25.RULE",
"rule_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/license-intro_25.RULE",
"matched_text": "licensed under the",
"matched_text_diagnostics": "licensed under the"

Line 274

The New Relic [security agent](https://github.com/newrelic/csec-node-agent) is licensed under the New Relic Software License v1.0.

  "license_expression": "unknown-spdx OR unknown-spdx OR unknown-spdx OR unknown-spdx OR unknown-spdx",
  "license_expression_spdx": "LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx OR LicenseRef-scancode-unknown-spdx",
  "from_file": "code/security-agent-2.0.0.tgz-extract/package/lib/instrumentation-security/index.js",
  "start_line": 3,
  "end_line": 3,
  "matcher": "1-spdx-id",
  "score": 100,
  "matched_length": 9,
  "match_coverage": 100,
  "rule_relevance": 100,
  "rule_identifier": "spdx-license-identifier-unknown_spdx_or_unknown_spdx_or_unknown_spdx_or_unknown_spdx_or_unknown_spdx-3beb51eb9537da51690a13a0a88961a707702c40",
  "rule_url": null,
  "matched_text": " * SPDX-License-Identifier: New Relic Software License v1.0",
  "matched_text_diagnostics": "SPDX-License-Identifier: New Relic Software License v1.0"

Note: The 4 "OR" from the license_expression is likely caused by the "spaces" after "SPDX-License-Identifier: "

[AyanSinhaMahapatra]

This is a new license which is neither present in SPDX nor in scancode, see https://github.com/newrelic/csec-node-agent/blob/main/LICENSE for the full text.
@DennisClark FYI

Many usages needs rules: https://github.com/search?q=%22New+Relic+Software+License+v1.0%22&type=code

• SPDX-License-Identifier: New Relic Software License v1.0

There seems to be an issue with non-spdx added licenses being declared like this, as this is not a valid SPDX identifier.
We should open an issue upstream neverthless after adding a license.

[AyanSinhaMahapatra]

See #4296