[For Review] Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies#5
Closed
ableegoldman wants to merge 25 commits into
Closed
Conversation
CVE-2021-26291, which makes Man-In-The-Middle-Attack possible, was fixed in maven 3.8.1. Reviewers: Luke Chen <showuon@gmail.com>, Manikumar Reddy <manikumar.reddy@gmail.com>
…apache#10375) Reviewers: Mickael Maison <mickael.maison@gmail.com>, Lee Dongjin <dongjin@apache.org>, Chris Egerton <fearthecellos@gmail.com>
…0724) Removal of methods already deprecated since 2.5. Adapt test to use the new alternative method. Reviewers: Bruno Cadonna <cadonna@apache.org>
Code samples are now unified and correctly formatted. Samples under Streams use consistently the prism library. Reviewers: Bruno Cadonna <cadonna@apache.org>
Introduce new AllocateProducerIds RPC and IBP 3.0-IV0 as part of KIP-730. This change adds a new AllocateProducerIds RPC which is used by the broker to request a block of producer IDs from the controller. The new IBP added will determine if the broker should talk directly to ZooKeeper (IBP < 3.0) or it if should use the new RPC to talk to the controller (IBP >= 3.0). Per-broker property overrides for ClusterTests were also added (in order to test mixed IBPs in a cluster) Reviewers: Colin P. McCabe <cmccabe@apache.org>
This PR tries to add the check for transaction timeout for a comparison against commit interval of streams. If transaction timeout is smaller than commit interval, stream should crash and inform user to update their commit interval to be larger or equal to the given transaction timeout, or vise versa. Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>, A. Sophie Blee-Goldman <sophie@confluent.io>
…lTest (apache#10703) Reviewers: Matthias J. Sax <matthias@confluent.io>
Reviewers: Matthias J. Sax <matthias@confluent.io>
…ns (apache#10742) When apache#10478 was merged, we accidentally lost the identifier/prefix string that we used to previously log to stderr from some of the functions in the Log class. In this PR, I have reinstated the identifier/prefix logging in these functions, so that the debuggability is restored. Reviewers: Luke Chen <showuon@gmail.com>, Cong Ding <cong@ccding.com>, Jun Rao <junrao@gmail.com>
…otent producer (apache#10690) The docs for the max.in.flight.requests.per.connection and enable.idempotence configs currently imply that setting the max in-flight request greater than 1 will break the message ordering guarantee, but that is only true if enable.idempotence is false. When using an idempotent producer, the max in-flight request can be up to 5 without re-ordering messages. Reviewers: Matthias J. Sax <mjsax@confluent.io>, Ismael Juma <mlists@juma.me.uk>, Luke Chen <showuon@gmail.com>
ableegoldman
force-pushed
the
12648-TopologyMetadata
branch
from
May 25, 2021 03:33
4b5a2c3 to
de43e2d
Compare
ableegoldman
force-pushed
the
12648-TopologyMetadata
branch
from
May 25, 2021 05:19
c95e083 to
93f0d0a
Compare
…che#10717) Reviewers: David Jacot <djacot@confluent.io>
ableegoldman
force-pushed
the
12648-TopologyMetadata
branch
from
May 26, 2021 01:28
c9eabcb to
ca3a0f2
Compare
ableegoldman
force-pushed
the
12648-TopologyMetadata
branch
from
May 26, 2021 03:10
351674c to
bddc293
Compare
ableegoldman
force-pushed
the
12648-TopologyMetadata
branch
from
May 26, 2021 03:46
5b43a06 to
e580d43
Compare
Owner
Author
|
This got a bit screwed up after rebasing on trunk, will open a new PR for reviewing against Pt. 1 |
Owner
Author
|
See #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as apache#10683 but targeted against apache#10609 to facilitate review and filter out everything except for the changes in this PR alone