cli: allow to start colima in the foreground #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
abiosoft
reviewed
Sep 3, 2023
|
Thanks for this :) |
|
I wasn't aware of other modes of colima. It looks like some tests/cleanup may require additional changes |
|
I've found out that integration tests fail because of: #796 |
|
@abiosoft Any chances for merge 🥺 ? |
Yeah, soon. |
abiosoft
reviewed
Sep 23, 2023
abiosoft
reviewed
Sep 23, 2023
regulskimichal
force-pushed
the
foreground
branch
from
d6b2839
to
b2aef24
Compare
regulskimichal
force-pushed
the
foreground
branch
from
b2aef24
to
1bc4637
Compare
abiosoft
approved these changes
Sep 24, 2023
abiosoft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Colima does not provide a working brew service. To make it possible, it should implement foreground mode. I'm pretty new to Golang but I think awaiting an interruption after the startup should be enough.