chore: refactor Makefile #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
abiosoft
reviewed
Jun 27, 2022
|
@abiosoft I still need/want to test this with nix. So can you hold on with the merge? |
That's fine by me. You can also mark the PR as draft and mark it as ready when you're done. |
tricktron
force-pushed
the
f-refactor-makefile-pr
branch
from
3480ca1 to
80dccea
Compare
|
@abiosoft I tested it with nix and it works. Could you run the workflows/tests to check if it does not break anything? |
abiosoft
reviewed
Jun 28, 2022
abiosoft
reviewed
Jun 28, 2022
abiosoft
approved these changes
Jun 28, 2022
abiosoft
added a commit
that referenced
this pull request
Jun 28, 2022
* refactor: extract build logic from build.sh to Makefile * chore: add test rule to Makefile * apply review suggestion Co-authored-by: Abiola Ibrahim <[email protected]> * fix: use defined `OUTPUT_DIR` variable * chore: remove -race flag from test as it needs CGO_ENABLED=1 * chore: generate sha in binaries directory * chore: propagate Go build environment variables Co-authored-by: Abiola Ibrahim <[email protected]>
abiosoft
added a commit
that referenced
this pull request
Jun 29, 2022
* chore: move CGO_ENABLE arg to makefile * chore: use actual current executable path * chore: fix generated binary on M1 mac * net: fix #344 qemu process missing gvproxy config * chore: update gitignore * chore: refactor, mock filesystem in tests * chore: update nix environment * chore: refactor Makefile (#354) * refactor: extract build logic from build.sh to Makefile * chore: add test rule to Makefile * apply review suggestion Co-authored-by: Abiola Ibrahim <[email protected]> * fix: use defined `OUTPUT_DIR` variable * chore: remove -race flag from test as it needs CGO_ENABLED=1 * chore: generate sha in binaries directory * chore: propagate Go build environment variables Co-authored-by: Abiola Ibrahim <[email protected]> * chore: disable CGO * chore: remove empty file Co-authored-by: tricktron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
VERSIONorOUTPUT_DIRvariables more easily. This is especially useful for package manager like nix.make test.