Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple image upload #84

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PiyushMishra318
Copy link

No description provided.

Copy link
Contributor

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@PiyushMishra318
Copy link
Author

@abi I wanted to discuss how you want to handle the UI for showing multiple images and the response for each image. If you want it separately or just in different sections in the same HTML.

@abi
Copy link
Owner

abi commented Nov 23, 2023

@PiyushMishra318 just the same HTML

@PiyushMishra318
Copy link
Author

@abi I've added a reference for how the response looks like when given multiple images.

Let me know if you have some input on this. I'll start working on the pdf input once I get your confirmation.

Screenshot 2023-11-27 at 9 57 53 AM

@abi abi changed the title Feat: Support uploading pdfs Support multiple image upload Jun 5, 2024
@abi
Copy link
Owner

abi commented Jun 5, 2024

@PiyushMishra318 is this PR still relevant? Is the goal to support multiple images? If so, I am interested in adding that ability.

@Shashir89
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants