-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode. #115
Dark mode. #115
Conversation
Apply Sweep Rules to your PR?
|
@abi do you plan on merging this? |
Yes probably tomorrow |
className="flex rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm transition-colors file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50t" | ||
onClick={() => { | ||
document | ||
.querySelector("div.mt-2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kachbit any idea why this needs to set separate instead of just having it set on the body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. I guess it is unnecessary, you can delete that part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work without it! I was curious if you knew why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are referring to the "// enable dark mode for sidebar" line, correct? I just ran it locally and it worked fine after I removed the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. It wasn't for me earlier. Let me try it out.
Thanks for this, @kachbit ! Would appreciate help keeping the dark mode working over time as we add new elements. |
Toggle dark mode feature accessible in the settings dialog.