Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode. #115

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Dark mode. #115

merged 13 commits into from
Nov 30, 2023

Conversation

kachbit
Copy link
Contributor

@kachbit kachbit commented Nov 28, 2023

Toggle dark mode feature accessible in the settings dialog.

Copy link
Contributor

sweep-ai bot commented Nov 28, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@kachbit
Copy link
Contributor Author

kachbit commented Nov 30, 2023

@abi do you plan on merging this?

@abi
Copy link
Owner

abi commented Nov 30, 2023

Yes probably tomorrow

@abi abi merged commit 226af5b into abi:main Nov 30, 2023
className="flex rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm transition-colors file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50t"
onClick={() => {
document
.querySelector("div.mt-2")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachbit any idea why this needs to set separate instead of just having it set on the body

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. I guess it is unnecessary, you can delete that part.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work without it! I was curious if you knew why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are referring to the "// enable dark mode for sidebar" line, correct? I just ran it locally and it worked fine after I removed the line.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. It wasn't for me earlier. Let me try it out.

@abi
Copy link
Owner

abi commented Nov 30, 2023

Thanks for this, @kachbit ! Would appreciate help keeping the dark mode working over time as we add new elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants