Skip to content

RING2-PKG-7: no-op — emitter already shipped in base#979

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/ring2-pkg-7-referenceindex-emission
Closed

RING2-PKG-7: no-op — emitter already shipped in base#979
Copilot wants to merge 2 commits into
mainfrom
copilot/ring2-pkg-7-referenceindex-emission

Conversation

Copilot AI commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Phase 5 of RFC #909 asks for a ReferenceIndex → graph-edge emitter with confidence/evidence JSON props and an opt-in ScopeTree flush. After investigation, the entire feature is already present in this branch's base commit (PR #973) — branch HEAD has zero diff against base for the feature scope.

Verification against deliverables

  • gitnexus/src/core/ingestion/emit-references.ts — iterates referenceIndex.bySourceScope, maps Reference.kind → existing RelationshipType (callCALLS, read/writeACCESSES with step=1|2, inheritsINHERITS, type-reference/import-useUSES), and stamps confidence + serialized evidence on each edge. Schema is preserved per the acceptance criterion.
  • Optional emitScopeGraph flush (Scope nodes + CONTAINS/DEFINES/IMPORTS) gated on INGESTION_EMIT_SCOPES=1 (1|true|yes, case-insensitive); off by default.
  • Unit suite at gitnexus/test/unit/scope-resolution/emit-references.test.ts — 12 tests covering kind mapping, enclosing-def resolution (function ancestor / class fallback / no-caller skip), missing-target skip, scope-graph on/off, env-flag parsing, empty-input no-op. Passes locally; tsc --noEmit clean.

Honest gap

The "full pipeline Python file → graph edges" integration test deliverable is not implementable yet: the resolution phase that populates ReferenceIndex from ReferenceSite records hasn't landed (see headers in emit-references.ts and finalize-orchestrator.ts:22). A hand-built ReferenceIndex test would duplicate the existing unit coverage without exercising new wiring. This integration test belongs in the resolution-phase PR, where it can consume real Reference records.

Diff in this PR

Single incidental change: gitnexus/package-lock.json re-synced from 1.6.11.6.2 to match package.json (produced by npm install during validation). No source changes.

Recommendation

Close as superseded by #973, or repurpose to track the resolution-phase integration test once that phase lands.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • extension.ladybugdb.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/GitNexus/GitNexus/gitnexus/node_modules/.bin/vitest run test/unit/scope-resolution/emit-references.test.ts yp lines; -I k/GitNexus/node_modules/.bin/node-gyp -I /home/REDACTED/.ca-c -I src/parser.o.d /hom�� e --64 es/.bin/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 19, 2026 that may be closed by this pull request
4 tasks
@vercel

vercel Bot commented Apr 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gitnexus Ready Ready Preview, Comment Apr 19, 2026 6:01am

Request Review

Copilot AI changed the title [WIP] Add ReferenceIndex emission to LadybugDB RING2-PKG-7: no-op — emitter already shipped in base Apr 19, 2026
Copilot AI requested a review from magyargergo April 19, 2026 06:03
Copilot AI added a commit that referenced this pull request Apr 19, 2026
magyargergo added a commit that referenced this pull request Apr 19, 2026
* Initial plan

* Plan: smarter index name inference via git remote URL

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* feat(cli): infer registry name from git remote.origin.url (#979)

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* refactor: skip git subprocess when --name was supplied (review feedback)

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* style: prettier --write on run-analyze.ts

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a4bf631d-ea6b-4d84-b426-29b1e5c3539f

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
github714801013 pushed a commit to github714801013/GitNexus that referenced this pull request Apr 28, 2026
…patwari#981)

* Initial plan

* Plan: smarter index name inference via git remote URL

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* feat(cli): infer registry name from git remote.origin.url (abhigyanpatwari#979)

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* refactor: skip git subprocess when --name was supplied (review feedback)

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

* style: prettier --write on run-analyze.ts

Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a4bf631d-ea6b-4d84-b426-29b1e5c3539f

Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RING2-PKG-7: ReferenceIndex emission to LadybugDB

2 participants