RING2-PKG-7: no-op — emitter already shipped in base#979
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
4 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Add ReferenceIndex emission to LadybugDB
RING2-PKG-7: no-op — emitter already shipped in base
Apr 19, 2026
Copilot AI
added a commit
that referenced
this pull request
Apr 19, 2026
Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
magyargergo
added a commit
that referenced
this pull request
Apr 19, 2026
* Initial plan * Plan: smarter index name inference via git remote URL Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * feat(cli): infer registry name from git remote.origin.url (#979) Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * refactor: skip git subprocess when --name was supplied (review feedback) Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * style: prettier --write on run-analyze.ts Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a4bf631d-ea6b-4d84-b426-29b1e5c3539f Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
github714801013
pushed a commit
to github714801013/GitNexus
that referenced
this pull request
Apr 28, 2026
…patwari#981) * Initial plan * Plan: smarter index name inference via git remote URL Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * feat(cli): infer registry name from git remote.origin.url (abhigyanpatwari#979) Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * refactor: skip git subprocess when --name was supplied (review feedback) Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/95064d2d-b1da-4c89-9069-5b3e9cc2636a Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * style: prettier --write on run-analyze.ts Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a4bf631d-ea6b-4d84-b426-29b1e5c3539f Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 of RFC #909 asks for a
ReferenceIndex→ graph-edge emitter withconfidence/evidenceJSON props and an opt-inScopeTreeflush. After investigation, the entire feature is already present in this branch's base commit (PR #973) — branch HEAD has zero diff against base for the feature scope.Verification against deliverables
gitnexus/src/core/ingestion/emit-references.ts— iteratesreferenceIndex.bySourceScope, mapsReference.kind→ existingRelationshipType(call→CALLS,read/write→ACCESSESwithstep=1|2,inherits→INHERITS,type-reference/import-use→USES), and stampsconfidence+ serializedevidenceon each edge. Schema is preserved per the acceptance criterion.emitScopeGraphflush (Scopenodes +CONTAINS/DEFINES/IMPORTS) gated onINGESTION_EMIT_SCOPES=1(1|true|yes, case-insensitive); off by default.gitnexus/test/unit/scope-resolution/emit-references.test.ts— 12 tests covering kind mapping, enclosing-def resolution (function ancestor / class fallback / no-caller skip), missing-target skip, scope-graph on/off, env-flag parsing, empty-input no-op. Passes locally;tsc --noEmitclean.Honest gap
The "full pipeline Python file → graph edges" integration test deliverable is not implementable yet: the resolution phase that populates
ReferenceIndexfromReferenceSiterecords hasn't landed (see headers inemit-references.tsandfinalize-orchestrator.ts:22). A hand-builtReferenceIndextest would duplicate the existing unit coverage without exercising new wiring. This integration test belongs in the resolution-phase PR, where it can consume realReferencerecords.Diff in this PR
Single incidental change:
gitnexus/package-lock.jsonre-synced from1.6.1→1.6.2to matchpackage.json(produced bynpm installduring validation). No source changes.Recommendation
Close as superseded by #973, or repurpose to track the resolution-phase integration test once that phase lands.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
extension.ladybugdb.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/GitNexus/GitNexus/gitnexus/node_modules/.bin/vitest run test/unit/scope-resolution/emit-references.test.ts yp lines; -I k/GitNexus/node_modules/.bin/node-gyp -I /home/REDACTED/.ca-c -I src/parser.o.d /hom�� e --64 es/.bin/sh(dns block)If you need me to access, download, or install something from one of these locations, you can either: