fix: register Section in NODE_TABLES and NODE_SCHEMA_QUERIES#401
Merged
Conversation
Parse .md/.mdx files using regex (no tree-sitter dependency) to extract: - Section nodes from headings (h1-h6) with hierarchy via CONTAINS edges - Cross-file IMPORTS edges from markdown links to other repo files Ported from #286 to resolve conflicts with kuzu→lbug rename. Co-Authored-By: Dennis Palatov <dp-web4@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…to feat/markdown-indexing
The Section schema was defined but not registered in NODE_TABLES or NODE_SCHEMA_QUERIES, so the table was never created in the database. Also adds missing FROM File TO Section relation entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
CI Report✅ All checks passed Pipeline
Tests
✅ All 3439 tests passed across 998 files 20 test(s) skipped
Coverage
📋 Full run · Coverage from Ubuntu · Generated by CI |
NODE_TABLES: 27→28, NODE_SCHEMA_QUERIES: 27→28, SCHEMA_QUERIES: 29→30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Show stdout/stderr in assertion message so CI failures reveal why the second analyze --skills run exits with code 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Section table has 8 columns (includes level) but getCopyQuery fell through to the default 7-column multi-language path. Adds explicit Section cases to getCopyQuery and insertNodeToLbug/upsertNodeToLbug. Error was: COPY failed for Section: Number of columns mismatch. Expected 7 but got 8. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xkonjin
reviewed
Mar 20, 2026
xkonjin
left a comment
There was a problem hiding this comment.
Code Review: Registers Section as a first-class node type for Markdown indexing support.
What looks good:
- Complete coverage: NODE_TABLES, NODE_SCHEMA_QUERIES, getCopyQuery, insertNodeToLbug, batchInsertNodesToLbug, and the File-to-Section relationship edge are all wired up.
- Section schema fields (level, content, startLine/endLine, description) are well chosen for Markdown heading hierarchy.
- Test updates for count assertions are correct (27->28 nodes, 29->30 total schemas).
- Better error diagnostics in skills-e2e.test.ts (stdout/stderr in assertion messages) is a nice improvement.
Suggestions:
- The comment in schema.test.ts still says '9 core + 18 multi-language = 27' but the count is now 28. The arithmetic comment should be updated to '9 core + 18 multi-language + 1 markdown = 28' for accuracy.
- Section only has a relationship FROM File TO Section. Consider whether Section-to-Section edges would be useful for representing heading nesting (h1 -> h2 -> h3). This could be a follow-up.
- No migration path mentioned. If existing indexed repos upgrade GitNexus, they will have the old 27-table schema. Will queries against Section fail gracefully, or does this require a re-analyze? Worth a note in the PR description.
- The COPY query column ordering must exactly match the CSV output from the analyzer. Verify the markdown parser emits columns in the same order (id, name, filePath, startLine, endLine, level, content, description).
abhigyanpatwari
pushed a commit
that referenced
this pull request
Mar 21, 2026
Release includes markdown indexing (#399) and the Section table registration fix (#401), making PR #403 unnecessary. https://claude.ai/code/session_015WxcTDYrGi4sWY8iY8gDZP
icodebuster
pushed a commit
to icodebuster/GitNexus
that referenced
this pull request
Mar 22, 2026
* main: (67 commits) fix(server): allow private/LAN network origins in CORS (abhigyanpatwari#390) fix(ingestion): calculate confidence per resolution tier for heritage/MRO edges (abhigyanpatwari#412) fix(lbug): retry on DB lock with session-safe cleanup (abhigyanpatwari#325) fix(analyze): address review — rename --no-git to --skip-git, fix stale cache fix(analyze): address Copilot review — ESM import, CLI option, .gitignore guard docs(schema): add Community and Process node properties to cypher tool description (abhigyanpatwari#411) fix(analyze): allow indexing folders without a .git directory (abhigyanpatwari#384) token trunking updated mahalanobis threshold to be multi-dim aware fix: clarify that ORT CUDA binaries are linux/x64 only updating workflow verbage fixed prop cutoff issue for pr/issue filtering fix: update symbol and relationship counts in documentation fix: address PR abhigyanpatwari#409 review findings (P0-P3) and simplify import resolution API refactor: unify language dispatch with compile-time exhaustive tables feat: implement cross-file binding propagation for multiple languages fix: hydrate worker DB in server mode + fix LadybugDB getAll API mismatch (abhigyanpatwari#398) (abhigyanpatwari#404) docs: add gitnexus-stable-ops to community integrations fix: register Section in NODE_TABLES and NODE_SCHEMA_QUERIES (abhigyanpatwari#401) feat: add markdown file indexing (headings + cross-links) (abhigyanpatwari#399) ...
2 tasks
motolese
pushed a commit
to motolese/datamoto-gitnexus
that referenced
this pull request
Apr 23, 2026
…npatwari#401) * feat: add markdown file indexing (headings + cross-links) Parse .md/.mdx files using regex (no tree-sitter dependency) to extract: - Section nodes from headings (h1-h6) with hierarchy via CONTAINS edges - Cross-file IMPORTS edges from markdown links to other repo files Ported from abhigyanpatwari#286 to resolve conflicts with kuzu→lbug rename. Co-Authored-By: Dennis Palatov <dp-web4@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add Section to NODE_TABLES and NODE_SCHEMA_QUERIES The Section schema was defined but not registered in NODE_TABLES or NODE_SCHEMA_QUERIES, so the table was never created in the database. Also adds missing FROM File TO Section relation entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update schema test counts for Section node type NODE_TABLES: 27→28, NODE_SCHEMA_QUERIES: 27→28, SCHEMA_QUERIES: 29→30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test: add diagnostic output to skills-e2e idempotency test Show stdout/stderr in assertion message so CI failures reveal why the second analyze --skills run exits with code 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add Section COPY query with level column in lbug-adapter Section table has 8 columns (includes level) but getCopyQuery fell through to the default 7-column multi-language path. Adds explicit Section cases to getCopyQuery and insertNodeToLbug/upsertNodeToLbug. Error was: COPY failed for Section: Number of columns mismatch. Expected 7 but got 8. --------- Co-authored-by: Dennis Palatov <dp-web4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sectionschema was defined but never registered, so the table was never created in the database'Section'toNODE_TABLESarraySECTION_SCHEMAtoNODE_SCHEMA_QUERIESarrayFROM File TO Sectionrelation entryError was:
Binder exception: Table Section does not existTest plan
🤖 Generated with Claude Code