feat: add --ignore-embeddings-node-limit flag to bypass 50K node cap#389
feat: add --ignore-embeddings-node-limit flag to bypass 50K node cap#389RyuzakiH wants to merge 1 commit into
Conversation
|
@RyuzakiH is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
| .option('--embeddings', 'Enable embedding generation for semantic search (off by default)') | ||
| .option('--ignore-embeddings-node-limit', 'Bypass the 50,000-node safety cap for embedding generation (use with --embeddings on large repos)') |
There was a problem hiding this comment.
We could merge them together and have
--embeddings [limit]
What do you think?
|
@claude review this, check for redundancies or misses in optimization for the method for this new flag. Can you also suggest an e2e test for this |
|
Claude finished @zander-raycraft's task in 1m 53s —— View job Code Review:
|
| Finding | Severity | Actionable? |
|---|---|---|
Silent no-op without --embeddings |
Medium | Yes — add a console.warn |
| No OOM warning when bypassing cap | Low | Yes — add advisory log |
--embeddings [limit] API design |
Design | Maintainer decision |
| Implementation logic | ✅ Correct | No changes needed |
|
@RyuzakiH can you address the issues raised in the comments above in a new commit to this pr? |
|
This is a must-have for Enterprise adoptions. We process and track context across multiple large repositories and enterprise codebases for autonomous agents (using OpenClaw MAS with 39 agents). The 50,000-node limit has been a hard blocker for computing the full blast radius on enterprise-scale mono-repos. We absolutely need the ability to compute full embeddings across large codebases, even if it takes more compute resources. This --ignore-embeddings-node-limit flag allows us to run DeepWiki generation on massive repos during CI/CD without the agent losing scope of distant dependencies. Tested this locally by patching our version and it works great. Looking forward to this getting merged. |
|
|
@magyargergo Hey! Also looking for this change, should I open a new PR? |
|
@JorrinKievit feel free to |
Summary
This PR adds a new CLI flag,
--ignore-embeddings-node-limit, to theanalyzecommand.When used together with
--embeddings, this flag bypasses the existing 50,000-node safety cap for embedding generation.It also updates the skip message to clearly inform users that they can override the limit with
--ignore-embeddings-node-limit.Closes #382
Changes
--ignore-embeddings-node-limitto theanalyzecommandTest Plan
npx gitnexus analyze --embeddingson a repository with more than 50,000 nodes and verify that embeddings are skipped with the updated message mentioning--ignore-embeddings-node-limitnpx gitnexus analyze --embeddings --ignore-embeddings-node-limiton the same repository and verify that embeddings are generatednpx gitnexus analyze --helpand verify that the new flag appears in the CLI help outputnpm test) and verify that there are no regressions