feat: AWS Neptune backend, COBOL support, Bedrock AI, TUI wizards & perf #343
Conversation
|
@naicud is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
|
This is very impressive work! Could you please split it up as the scope is hug. |
|
Hi @magyargergo, thanks for raising this I totally understand the concern around the size of the PR. I did evaluate splitting it, but given how tightly the components are coupled, breaking it up would actually introduce more risk than it removes. Each part depends on the others to function correctly, and reviewing them in isolation could create a false sense of safety changes that look fine individually might only surface issues when integrated. Keeping it as a single PR gives us full visibility over the impact of each change, and ensures the review reflects the actual behaviour of the system. I'm happy to make the review easier in other ways for example, I can walk you through the code structure in a short call, add more inline documentation, or break down the PR description by logical area so it's easier to navigate. Let me know what works best for you. Thanks, |
|
@claude can you recommend a splicing strategy for this PR to reduce the scope of the task? Such as the language support can go into a separate PR. As I want to see how good coverage they got for the COBOL language support and would be interested how they tackled with the specific language challenges. |
|
Claude finished @magyargergo's task in 2m 49s —— View job PR Splitting Strategy
Based on exploring the actual codebase, here is a recommended split into 5 focused PRs, ordered from least to most coupled: PR 1 — COBOL Language Support (most self-contained — start here)Files involved:
Why it can stand alone: COBOL support has zero dependencies on Neptune, Bedrock, or the embed command. It plugs in as a new language parser behind a feature-flagged code path ( Questions worth asking in review:
PR 2 —
|
| Feature | Depends on |
|---|---|
| COBOL | (nothing new) — pure addition to existing ingestion pipeline |
| TUI Wizards | Existing commands; conditionally references Neptune config types |
| Neptune | IDbQueryAdapter interface (additive); optionally uses embeddings |
| Bedrock | Server API (additive proxy routes only) |
| LOD Rendering | Server API (additive endpoints); community detection (existing) |
Suggested Review Order
PR 1: COBOL ← review independently right now
PR 2: TUI + embed CLI ← can be reviewed in parallel with COBOL
PR 3: Neptune ← after interfaces.ts changes are agreed on
PR 4: Bedrock ← anytime, fully independent
PR 5: Perf + LOD ← last, most risk to existing behavior
The key counterargument from the author (that the components are "tightly coupled") doesn't hold up against the actual code structure — the Neptune and COBOL changes integrate via clean adapter interfaces and conditional code paths, not intertwined logic.
|
Hey @zander-raycraft, thanks for all the work on this PR. Unfortunately, due to a CI workflow issue, this PR was accidentally merged into main and we had to force-push to restore the correct history. The PR is now in a broken state (marked as merged but the commits aren't on main). Could you re-submit your changes as separate PRs following the splitting strategy Claude suggested earlier? Here's the recommended breakdown:
Suggested review order: See the full splitting analysis for detailed file lists, coupling notes, and review questions for each PR. Splitting these up will make review much more manageable and reduce the risk of regressions. Let us know if you have any questions! |
|
@magyargergo do you want an help ? |
Yes please 🙏 I'm quite busy at the moment so if you could split up your changes into 5 separate PRs, that would be greatly appriciated and would be a great help! |
|
@magyargergo I'm trying to split in 5 PR but we will have some conflicts |
|
┌─────┬─────────────────────────┬──────┬────────┐ |
|
Hey @magyargergo Did you mean to tag me in this PR? IF you need me to work on this I am happy to, I think this may be @naicud's PR and it looks like he is doing some stuff with it! If not then lmk what you do need help with! |
Summary
This PR adds several major features developed in parallel on top of upstream:
🗄️ AWS Neptune Graph Backend
--db neptune,--neptune-endpoint,--neptune-region)/api/db/test+ MCP dispatch for Neptune queries🏢 COBOL Language Support
GITNEXUS_COBOL_DIRSenv var for extensionless file detection🤖 AWS Bedrock Integration
/api/bedrock/health,/api/bedrock/converse)🖥️ TUI Improvements
analyzeandwikicommands--yesflag to skip prompts in CI environments⚡ Performance & Rendering
fastStripNullable,skipGraphPhases, AST pruning optimizations📦 New CLI Command
gitnexus embed— standalone command to generate/update embeddingsTest plan
gitnexus analyzeworks unchanged on TS/JS repos (LedyBugDB path untouched)gitnexus analyze --db neptune --neptune-endpoint <host>ingests to NeptuneGITNEXUS_COBOL_DIRS=s,cand run analyze on a COBOL repo/api/bedrock/healthgitnexus analyze(interactive mode)gitnexus embedgenerates embeddings without re-analyzing