refactor(ingestion): delete shadow harness (RING4-3, #944)#2071
Merged
magyargergo merged 1 commit intoJun 7, 2026
Merged
Conversation
…gyanpatwari#944) Ring 4 retires the legacy call-resolution DAG. With the legacy resolver gone (RING4-1 abhigyanpatwari#942, RING4-2 abhigyanpatwari#943), shadow mode has nothing to dual-run against, so the remaining shadow-mode artifacts are dead code. - Delete gitnexus-shared/src/scope-resolution/shadow/{diff,aggregate}.ts (pure parity comparison logic) and its gitnexus-shared barrel exports. - Delete the static parity dashboard (gitnexus/shadow-parity-dashboard/), which also removes the last GITNEXUS_SHADOW_MODE reference in the repo. - Delete the shadow-mode unit tests (gitnexus/test/unit/shadow/). - Scrub stale doc comments referencing the shadow harness / parity dashboard / removed legacy run (csharp/php/python/typescript index.ts, evidence.ts, module-scope-index.ts). Already removed by RING4-1/-2 (verified): the shadow harness source and GITNEXUS_SHADOW_MODE env handling; no CI job published dashboard artifacts. Historical parity records preserved per acceptance: the CHANGELOG entry (abhigyanpatwari#918, abhigyanpatwari#923, abhigyanpatwari#951, abhigyanpatwari#972) and the ci.yml RING4-1 note remain. Last documented parity state is that historical coverage — no live .gitnexus/shadow-parity/ run data exists in-tree (runtime output only). Closes abhigyanpatwari#944. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@magyargergo is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
CI Report✅ All checks passed Pipeline Status
Test Results
✅ All 10595 tests passed 16 test(s) skipped — expand for details
Code CoverageTests
📋 View full run · Generated by CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
RING4-3 of the RFC #909 Ring 4 DAG-retirement series. Ring 4 deletes shadow mode — once the legacy call-resolution DAG is gone, dual-run has nothing to shadow. RING4-1 (#942 / #2023) deleted the legacy DAG; RING4-2 (#943 / #2033) deleted the resolution-context tiered lookup. This PR removes the last shadow-mode artifacts.
A pre-flight audit found the remaining scope is narrower than the issue checklist — RING4-1/-2 had already removed the shadow harness source, the
GITNEXUS_SHADOW_MODEenv handling, and the CI dashboard-publish job. What was left was orphaned dead code.This is a pure deletion. No production code consumes the removed symbols (verified by reference search across
gitnexus/src,gitnexus/test, andgitnexus-shared/src) — the only references were the package barrel re-export and the shadow-mode unit tests, both removed here.Changes
gitnexus-shared/src/scope-resolution/shadow/{diff,aggregate}.ts— the pure shadow-mode parity comparison logic — and its 7gitnexus-sharedbarrel exports (diffResolutions,aggregateDiffs,ShadowAgreement,ShadowCallsite,ShadowDiff,LanguageParityRow,ShadowParityReport).gitnexus/shadow-parity-dashboard/— the static parity dashboard. This also removes the lastGITNEXUS_SHADOW_MODEreference in the repo.gitnexus/test/unit/shadow/{diff,aggregate}.test.ts— tests of the deleted logic.csharp/php/python/typescriptindex.ts,evidence.ts, andmodule-scope-index.ts.12 files changed, +15 / −1062.
Issue deliverables
GITNEXUS_SHADOW_MODEhandlingAcceptance
shadow-candidateslogic, LadybugDBmissing-shadowWAL sidecars, and lexical variable-shadowing docs.CHANGELOGentry (RING2-SHARED-7: Shadow-mode diff and aggregation (pure) #918, RING2-PKG-5: Shadow harness + parity dashboard #923, scaffold(shared): shadow diff + aggregate skeletons (#918, RFC #909 Ring 2 SHARED) #951, feat(ingestion): shadow-mode parity harness + static dashboard (#923, RFC #909 Ring 2 PKG) #972) and theci.ymlRING4-1 note remain..gitnexus/shadow-parity/run data exists in-tree (runtime output only); the documented last-known parity state is the historical CHANGELOG coverage, noted in the merge commit.Out of scope (intentionally untouched)
Unrelated "shadow" concepts:
shadow-candidates.ts(incremental seeding), LadybugDB missing-shadow WAL sidecars, variable-shadowing docs/fixtures, CSSbox-shadow, and the golden capture-parity test.Testing
gitnexus-sharedbuilds clean (tsc);gitnexusbuilds clean; full unit suite green after a fresh build (the deleted shadow tests removed, no remaining test references the removed symbols). Reference sweeps confirm zero dangling references to the deleted symbols, files, orshadow-parity-dashboard.Closes #944.
🤖 Generated with Claude Code
CI Failures Unresolved
One check is red and is not code-fixable from this PR:
All functional CI gates pass, including the aggregate CI Gate: multi-platform
tests/*(ubuntu / macOS / windows, packaged-install smoke, benchmarks, tree-sitter ABI ×3),quality/*(format, lint, typecheck, typecheck-web), Build & Push (gitnexus + gitnexus-web), Analyze (python + js/ts), CodeQL, and the e2e web-module check (chromium e2e correctly skipped — no web changes). This PR is mergeable on its functional checks.