-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix(vue): F89 JSDoc fix, F90 dual-script merge, F92 lang plumbing (#1936) #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magyargergo
merged 9 commits into
abhigyanpatwari:main
from
prajapatisparsh:fix/vue-sfc-coverage
Jun 7, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
98624a9
fix(vue): F89 JSDoc fix, F90 dual-script merge, F92 lang plumbing (#1…
prajapatisparsh 8b5e30d
Merge branch 'main' into fix/vue-sfc-coverage
magyargergo 8903a0c
fix(vue): reviewer fixes — P1 lang routing, P2 lineOffset, P2/P3 pipe…
prajapatisparsh 7cb3c88
Merge branch 'main' into fix/vue-sfc-coverage
magyargergo 7e3187f
fix(vue): add jsx to lang routing condition
prajapatisparsh b6531e6
Merge branch 'main' into fix/vue-sfc-coverage
magyargergo 447e4c3
fix(vue): update F90/F92 fixtures and test assertions for CI
prajapatisparsh 8e92c00
Merge branch 'main' into fix/vue-sfc-coverage
magyargergo babc6c4
Merge branch 'main' into fix/vue-sfc-coverage
magyargergo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
gitnexus/test/fixtures/lang-resolution/js-parsing-coverage/class-expression.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // F44: Class expression — should produce a Class scope for the expression body | ||
| // On main: no @scope.class emitted → methods have no Class parent | ||
| // On this branch: (class) @scope.class emitted → methods get Class scope | ||
| export const instance = class { | ||
| greet(): string { | ||
| return 'hello'; | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <template> | ||
| <div>Hello</div> | ||
| </template> | ||
| <script> | ||
| function legacySetup() { | ||
| return { count: 0 }; | ||
| } | ||
| </script> | ||
| <script setup lang="ts"> | ||
| function setupInit() { | ||
| return 42; | ||
| } | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <template> | ||
| <div>Hello</div> | ||
| </template> | ||
| <script lang="js"> | ||
| function greet(name) { | ||
| return 'Hello ' + name; | ||
| } | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2/P3 — testing, code-read] This fixture (and
vue-dual-script/App.vue) is referenced by no test — a repo-wide grep finds zero consumers. The integration suitetest/integration/resolvers/vue-scope.test.tsloads fixtures by explicit path and runs onlyvue-composition-api/vue-options-api/vue-cross-file; these new dirs also lack thesrc/mini-repo layout those use. So the JS-lang routing and the dual-script merge are covered only by the pure-extractVueScriptunit tests — never end-to-end, and never on the worker path (which would expose the deadsetupLang).Actionable path: add
describeblocks tovue-scope.test.tsthat runrunPipelineFromRepoagainst these fixtures and assert symbols from both blocks / JS-style captures appear — or remove the fixtures.[code-read]