fix(test): use retry cleanup in antigravity e2e to prevent ENOTEMPTY flake#1838
Merged
Conversation
…flake Replace bare `fsp.rm` / `fs.rmSync` in antigravity-hook-e2e.test.ts afterAll with `cleanupTempDir` / `cleanupTempDirSync` from test-db.ts which retry with backoff on transient filesystem errors. Also make `shouldSwallowCleanupError` swallow ENOTEMPTY on all platforms (was Windows-only). The CI failure on macOS was ENOTEMPTY on a deeply nested node-gyp cache directory inside the temp HOME — a cleanup-time race that retries usually resolve, but the final attempt must not crash the test suite if the race persists.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
CI Report✅ All checks passed Pipeline Status
Test Results
✅ All 9883 tests passed 3 test(s) skipped — expand for details
Code CoverageTests
📋 View full run · Generated by CI |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
fsp.rm/fs.rmSyncinantigravity-hook-e2e.test.tsafterAll with the existingcleanupTempDir/cleanupTempDirSynchelpers fromtest/helpers/test-db.tswhich retry with exponential backoff on transient filesystem errors.Also extend
shouldSwallowCleanupErrorto swallowENOTEMPTYon all platforms (was Windows-only). The CI failure on macOS wasENOTEMPTYon a deeply nestednode-gypcache directory inside the temp HOME — a cleanup-time race that retries usually resolve, but the final attempt must not crash the test suite if the race persists.Changes
antigravity-hook-e2e.test.ts: import and usecleanupTempDir/cleanupTempDirSyncinstead of barefsp.rm/fs.rmSynctest/helpers/test-db.ts: swallowENOTEMPTYon all platforms after retry exhaustionTest plan
ENOTEMPTYerror from CI run would be retried then swallowed