fix(group): move manifest/workspace extraction before closeLbug (#1802)#1807
Merged
Merged
Conversation
syncGroup closed all LadybugDB pools in `finally` before running discoverWorkspaceLinks and ManifestExtractor.extractFromManifest, causing executor closures to resolve against dead pools. Restructure so both run inside an outer try block with pools still open; the finally now fires only after manifest/workspace processing completes. Adds regression test proving executeParameterized fires before closeLbug and that the resulting cross-link uses the real DB UID.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
CI Report✅ All checks passed Pipeline Status
Test Results
✅ All 9707 tests passed 1 test(s) skipped — expand for details
Code CoverageTests
📋 View full run · Generated by CI |
Replace toBeGreaterThan(0) with exact counter values per DoD §2.7.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ng check Instead of hard-coding executeParameterized call counts (which depend on internal HttpRouteExtractor behavior), detect manifest-specific resolution by matching the HANDLES_ROUTE query and record whether closeLbug had already fired at that point. This decouples the ordering proof from unrelated extractor internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncGroupclosed LadybugDB pools before runningdiscoverWorkspaceLinksandManifestExtractor.extractFromManifest, causing "LadybugDB not initialized" warning spam and loss of graph-backed manifest symbol resolutiontryblock with pools still open;finallycloses pools only after processing completes or throwsexecuteParameterizedfires beforecloseLbugand that manifest cross-links use real DB UIDs (not synthetic fallback)Test plan
npm run test:unit -- test/unit/group/sync.test.ts— all pass (including new ordering test)npm run test:unit -- test/unit/group/manifest-extractor.test.ts— all passnpx tsc --noEmit— cleanextractorOverrideno-DB path still produces synthetic UIDsCloses #1802