Skip to content

fix(test): widen worker pool retry timeout to prevent CI flake (#1323)#1354

Merged
magyargergo merged 1 commit into
abhigyanpatwari:mainfrom
azizur100389:fix/worker-pool-test-flake
May 5, 2026
Merged

fix(test): widen worker pool retry timeout to prevent CI flake (#1323)#1354
magyargergo merged 1 commit into
abhigyanpatwari:mainfrom
azizur100389:fix/worker-pool-test-flake

Conversation

@azizur100389

Copy link
Copy Markdown
Contributor

Summary

  • The replaces a timed-out worker and retries with a longer timeout test used a 150 ms idle timeout (subBatchIdleTimeoutMs: 150), leaving almost no headroom when CI runners are under load.
  • Widens the timeout to 500 ms; with the existing timeoutBackoffFactor: 4, the retry fires at 2 000 ms instead of 600 ms, giving the worker time to respond before the assertion window closes.
  • Updates the matching assertion from 'Retrying with 0.6s timeout' to 'Retrying with 2s timeout'.

Test plan

  • npx vitest run test/integration/worker-pool.test.ts — all 22 tests pass
  • No other test uses the same 150 ms value in a way that would be affected

Closes #1323

…yanpatwari#1323)

The retry-timeout test used a 150ms idle timeout, leaving almost no
headroom under CI load. Widen to 500ms (with the 4x backoff factor the
retry fires at 2s) so the worker has time to respond before the
assertion window closes.
@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

@azizur100389 is attempting to deploy a commit to the NexusCore Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
8023 8022 0 1 373s

✅ All 8022 tests passed

1 test(s) skipped — expand for details
  • buildTypeEnv > known limitations (documented skip tests) > Ruby block parameter: users.each { |user| } — closure param inference, different feature

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 77.6% 24481/31545 77.02% 📈 +0.6 🟢 ███████████████░░░░░
Branches 66.19% 15520/23447 65.97% 📈 +0.2 🟢 █████████████░░░░░░░
Functions 82.81% 2419/2921 81.86% 📈 +1.0 🟢 ████████████████░░░░
Lines 80.63% 22103/27410 79.89% 📈 +0.7 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@magyargergo magyargergo merged commit e60e62f into abhigyanpatwari:main May 5, 2026
29 of 30 checks passed
@magyargergo magyargergo mentioned this pull request May 10, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] Worker pool retry test flakes under load — 150ms idle timeout too tight

2 participants