Skip to content

test(ignore-service): skip EACCES test under uid=0 (root bypasses chmod) #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magyargergo merged 1 commit into from
Apr 27, 2026
Merged

test(ignore-service): skip EACCES test under uid=0 (root bypasses chmod) #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions gitnexus/test/unit/ignore-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,21 +561,30 @@ describe('loadIgnoreRules — error handling', () => {
await fs.rm(tmpDir, { recursive: true, force: true });
});

it.skipIf(process.platform === 'win32')('warns on EACCES but does not throw', async () => {
const gitignorePath = path.join(tmpDir, '.gitignore');
await fs.writeFile(gitignorePath, 'data/\n');
await fs.chmod(gitignorePath, 0o000);

const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
const result = await loadIgnoreRules(tmpDir);
// Should still return (null or partial), not throw
expect(result).toBeNull();
expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining('.gitignore'));

warnSpy.mockRestore();
await fs.chmod(gitignorePath, 0o644);
await fs.unlink(gitignorePath);
});
// Also skip under uid=0: root bypasses POSIX read-permission checks, so
// chmod 000 does NOT trigger EACCES — fs.readFile reads the file anyway
// and loadIgnoreRules returns parsed rules instead of null. This makes
// the test fail in any privileged environment (rootful Docker, CI runners
// configured with root). The non-root branch still exercises the real
// EACCES path; root just can't reproduce the failure mode.
it.skipIf(process.platform === 'win32' || process.getuid?.() === 0)(
'warns on EACCES but does not throw',
async () => {
const gitignorePath = path.join(tmpDir, '.gitignore');
await fs.writeFile(gitignorePath, 'data/\n');
await fs.chmod(gitignorePath, 0o000);

const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
const result = await loadIgnoreRules(tmpDir);
// Should still return (null or partial), not throw
expect(result).toBeNull();
expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining('.gitignore'));

warnSpy.mockRestore();
await fs.chmod(gitignorePath, 0o644);
await fs.unlink(gitignorePath);
},
);
});

describe('loadIgnoreRules — GITNEXUS_NO_GITIGNORE env var', () => {
Expand Down
Loading