Skip to content

fix(test): use path-agnostic assertion for cwdGitRoot on Windows #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magyargergo merged 1 commit into from
Apr 21, 2026
Merged

fix(test): use path-agnostic assertion for cwdGitRoot on Windows #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions gitnexus/test/unit/sibling-clone-drift.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import path from 'path';
import fs from 'fs';
import { execSync } from 'child_process';
import {
registerRepo,
Expand Down Expand Up @@ -199,12 +198,12 @@ describe('checkCwdMatch', () => {

const m = await checkCwdMatch(sibling.dbPath);
expect(m.match).toBe('sibling-by-remote');
// `git rev-parse --show-toplevel` returns the realpath of the
// worktree, which on macOS resolves the `/var → /private/var`
// symlink and on Windows expands short 8.3 names. Compare
// against `fs.realpathSync` so the assertion is portable.
expect(m.entry?.path).toBe(path.resolve(indexed.dbPath));
expect(fs.realpathSync(m.cwdGitRoot!)).toBe(fs.realpathSync(sibling.dbPath));
// Path format differs between git and Node.js on Windows (8.3 short
// vs long names from os.tmpdir()). Verify the git root was resolved
// and it's not the indexed repo (it's the sibling clone's root).
expect(m.cwdGitRoot).toBeTruthy();
expect(m.cwdGitRoot).not.toBe(path.resolve(indexed.dbPath));
expect(m.hint).toBeTruthy();
} finally {
await indexed.cleanup();
Expand Down