Skip to content

Commit

Permalink
add @taskr/esnext to pnpm root to resolve hoisting issues (vercel#70349)
Browse files Browse the repository at this point in the history
### What?

Add `@taskr/esnext` to the root package.json to get around hoisting
rules breaking `taskr`'s automatic discovery (and fix builds on some
platforms where it is broken).

### Why?

Some types of 'magically' imported packages (such as taskr automatically
supporting es6 by just adding a package, or drizzle automatically
finding a database driver) aren't hoisted on some platforms in the way
the tool expects, breaking it. The symptom of this is taskr throwing a
syntax error on some platforms, because we use ES6 syntax and it can't
find the package it needs to support it.

### How?

By adding it to the root package.json we ensure it is always hoisted in
the way taskr expects.
  • Loading branch information
arlyon authored Sep 25, 2024
1 parent f7fca5d commit 178f8a0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
"@swc/core": "1.6.13",
"@swc/helpers": "0.5.13",
"@swc/types": "0.1.7",
"@taskr/esnext": "1.1.0",
"@testing-library/jest-dom": "6.1.2",
"@testing-library/react": "^15.0.5",
"@types/busboy": "1.5.3",
Expand Down
19 changes: 8 additions & 11 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 178f8a0

Please sign in to comment.