Add the Phi 3 mini chat format #1383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's getting weird over on HF. MS has revised the Phi-3 chat format to completely ignore the system role, and are telling consumers to rewrite their prompt structures instead. https://huggingface.co/microsoft/Phi-3-mini-4k-instruct/discussions/51 |
|
@abetlen Is there any way I can help? Would be nice to get the phi 3 format in, now that the larger models have been released. |
ihendley
reviewed
May 23, 2024
| @@ -1325,6 +1331,27 @@ def format_gemma( | |||
| _prompt = _format_no_colon_single(system_message="", messages=_messages, sep=_sep) | |||
| return ChatFormatterResponse(prompt=_prompt, stop=_sep) | |||
|
|
|||
| @register_chat_format("phi_3_mini") | |||
There was a problem hiding this comment.
Better to call it just "phi-3" here and elsewhere
ihendley
reviewed
May 23, 2024
| assistant="<|assistant|>", | ||
| system="<|system|>" | ||
| ) | ||
| _begin_token = "<s>" |
There was a problem hiding this comment.
I don't see <s> in the technical report. Are you sure you need this?
|
Any success in merging this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*my first PR :)