Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require typing_extensions on Python < 3.11 #57

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

encukou
Copy link
Contributor

@encukou encukou commented May 28, 2024

asgi_typing.py has:

if sys.version_info >= (3, 11):
    from typing import NotRequired
else:
    from typing_extensions import NotRequired

However, typing_extensions was not listed as a runtime requirement. If a2wsgi was installed without its test dependencies (which themselves require typing_extensions), it failed to import.

Fixes: #52

@abersheeran abersheeran merged commit aaf1733 into abersheeran:master Jun 26, 2024
1 of 16 checks passed
@encukou encukou deleted the require-typing_extensions branch June 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a2wsgi needs typing_extensions on older Python versions
2 participants