fix: damf context elements from local imports #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a theorem uses a lemma that was locally imported (not previously existing as damf assertion, neither in the same file; but imported from a local file), this lemma was not being tracked as a damf dependency in the published theorem of the main file
relevant damf context elements (Kind, Type, Define, etc..) were not being considered and added to the compiled damf formulas contexts if they're introduced in locally imported files (for example, when we import "ccs_sig", all damf context elements in it were not being considered)
|
I am not sure this is correct. |
|
Fixed in c7285e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant damf context elements (Kind, Type, Define, etc..) were not being considered and added to the compiled damf formulas contexts if they're introduced in locally imported files (for example, when we import "ccs_sig", all damf context elements in it were not being considered)