Only import enum34 on python versions < 3.4#4
Merged
Conversation
Contributor
Author
|
Did you have a chance to take a look at this PR? |
abdullahselek
approved these changes
Jun 18, 2019
Owner
abdullahselek
left a comment
abdullahselek
left a comment
There was a problem hiding this comment.
Sorry for being late, looks good to me thanks for your contribution!
Contributor
Author
|
Thanks! |
Owner
|
Yes I will, but I’m in a holiday right now and don’t have my computer with me. Will let you know when I release a new version. |
Contributor
Author
|
Thank you! Enjoy your holiday ;-) |
Owner
|
Hey @eifinger I just want to let you know that I've just release version |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum34 breaks python environments which are 3.6 or later.
With this PR it is only required when 3.4 or earlier is detected