Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributePrefix cannot be empty string #36

Open
davemevans opened this issue Sep 2, 2016 · 0 comments
Open

attributePrefix cannot be empty string #36

davemevans opened this issue Sep 2, 2016 · 0 comments

Comments

@davemevans
Copy link

Currently our project uses version 1.0.11, and we set attributePrefix to ''.

We are looking at upgrading to the latest version, but this will not allow attributePrefix to be an empty string since empty strings are falsy and therefore config.attributePrefix || "_" returns "_".

It would be great if x2js explicitly checked for undefined for this option rather than falsy-ness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant