-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userUpdate): Uncached users throwing undefined #1366
Conversation
when you update the bot username or avatar or discriminator it fires an undefined on the userUpdate event.
- rename "main" to "upstream" - add "everything-v10" branch Additions: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1332 - abalabahaha/eris#1344 - abalabahaha/eris#1351 - abalabahaha/eris#1355 - abalabahaha/eris#1358 - abalabahaha/eris#1359 - abalabahaha/eris#1363 - abalabahaha/eris#1366 - abalabahaha/eris#1367 - abalabahaha/eris#1368 - abalabahaha/eris#1369 - abalabahaha/eris#1370 Removals: - abalabahaha/eris#1305 - abalabahaha/eris#1314 - abalabahaha/eris#1325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not merging yet
@bsian03 The old logic should be fine btw because USER_UPDATE fires only with the current user update ( the bot ) in our case which should always be cached on ready the cache was fine, the issue was user.update() does not return anything, and its actually not being used outside so I used client.users.update() instead Line 37 in 017c18a
the event userUpdate on eris is used when members get updated too. which different than discord USER_UPDATE ^ just to clerify |
That was my brain freaking out that the thing would've been breaking (didn't clock it would be only the bot earlier, but did last night), hence the change. Also you missed out the client param in the update. Oh well, doesn't hurt to have a fallback. Who knows, discord might change something 🤷 |
Removals: - (merged) abalabahaha/eris#1351 - (merged) abalabahaha/eris#1355 - (merged) abalabahaha/eris#1366 - (issues) abalabahaha/eris#1368 Additions: - abalabahaha/eris#1376
when you update the bot username or avatar or discriminator it fires an undefined on the userUpdate event.