-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interactions): Interactions Refactor #1309
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonovanDMC
changed the title
Rewrite Some Interaction Types
Various Interactions Changes
Nov 28, 2021
DonovanDMC
force-pushed
the
interactions-rewrite
branch
from
November 28, 2021 23:59
93357d7
to
a5e4619
Compare
eritbh
suggested changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one plural type name, also found a bug from the original implementation that should be corrected
Co-authored-by: Erin <[email protected]>
eritbh
previously approved these changes
Nov 29, 2021
DonovanDMC
added a commit
to DonovanArchive/ErisPRUpdateBot
that referenced
this pull request
Dec 9, 2021
- Add abalabahaha/eris#1309 - Add abalabahaha/eris#1311 - Removed Merged/Outdated
bsian03
changed the title
Various Interactions Changes
refactor(interactions): Redo types and remove unnecessary data
Dec 20, 2021
DonovanDMC
changed the title
refactor(interactions): Redo types and remove unnecessary data
refactor(interactions): Interactions Refactor
Jun 18, 2022
DonovanDMC
force-pushed
the
interactions-rewrite
branch
2 times, most recently
from
July 5, 2022 16:44
3bb016f
to
09aaa12
Compare
Don't mind the force pushing mess, I somehow managed to cherry pick the new dev commits instead of merging them some time back, they've been properly merged in now |
Jam-Manbo
pushed a commit
to Manbo-js/manbo
that referenced
this pull request
Sep 28, 2022
This was referenced Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently interactions can be hard to use due to the way the types have been made. This pull request completely rewrites most things surrounding interactions.
To Use In Projects
npm i DonovanDMC/eris#interactions-rewrite
I'd also recommend looking into everything and everything-v10