Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text in Guild Voice Channels #1298

Merged
merged 21 commits into from
Jun 1, 2022
Merged

Text in Guild Voice Channels #1298

merged 21 commits into from
Jun 1, 2022

Conversation

beanjo55
Copy link
Contributor

@beanjo55 beanjo55 commented Nov 15, 2021 •
edited by DonovanDMC
Loading

Adds support for upcoming text in guild voice channels, draft until discord finalizes the spec for them and is no longer subject to change. Only applies to GUILD_VOICE, stage channels not included

TODO:

  • Create GuildVoiceChannel class, extends VoiceChannel, and add appropriate text props since no multiple inheritance :(
  • Update channel struct to use new GuildVoiceChannel class
  • First pass as TS typings
  • Check jsdoc to use the new channel class and the channel is referenced where appropriate
  • Fix TS type issue with messages collection
  • Ensure lint is correct

Please let me know if i missed anything, or if theres a better or more appropriate way to implement!

Fixes #1381

@bsian03 bsian03 mentioned this pull request Apr 23, 2022
Closed
DonovanDMC
DonovanDMC reviewed Apr 23, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
DonovanDMC
DonovanDMC reviewed Jun 1, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@DonovanDMC DonovanDMC mentioned this pull request Jun 1, 2022
Closed
@DonovanDMC DonovanDMC marked this pull request as ready for review June 1, 2022 22:41
bsian03
bsian03 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are any more issues, we can fix them in subsequent PRs

@bsian03 bsian03 merged commit d6df49a into abalabahaha:dev Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonovanDMC DonovanDMC DonovanDMC approved these changes

@bsian03 bsian03 bsian03 approved these changes

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text in voice channels crashing
3 participants
@beanjo55 @DonovanDMC @bsian03