fix(editChannel): fix videoQualityMode & add permissionOverwrites (…

…#1319)
abalabahaha · Jun 8, 2022 · ba4cb94 · ba4cb94
1 parent 99b1376
commit ba4cb94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -277,7 +277,7 @@ declare namespace Eris {
     topic?: string;
     userLimit?: number;
   }
-  interface EditChannelOptions extends Omit<CreateChannelOptions, "permissionOverwrites" | "reason"> {
+  interface EditChannelOptions extends Omit<CreateChannelOptions, "reason"> {
     archived?: boolean;
     autoArchiveDuration?: AutoArchiveDuration;
     defaultAutoArchiveDuration?: AutoArchiveDuration;

diff --git a/lib/Client.js b/lib/Client.js
@@ -479,7 +479,7 @@ class Client extends EventEmitter {
     * @arg {Number} [options.bitrate] The bitrate of the channel (voice channels only)
     * @arg {Boolean} [options.nsfw] The nsfw status of the channel
     * @arg {String?} [options.parentID] The ID of the parent category channel for this channel
-    * @arg {Array} [options.permissionOverwrites] An array containing permission overwrite objects
+    * @arg {Array<Object>} [options.permissionOverwrites] An array containing permission overwrite objects
     * @arg {Number} [options.position] The sorting position of the channel
     * @arg {Number} [options.rateLimitPerUser] The time in seconds a user has to wait before sending another message (does not affect bots or users with manageMessages/manageChannel permissions) (text channels only)
     * @arg {String} [options.reason] The reason to be displayed in audit logs
@@ -1252,6 +1252,7 @@ class Client extends EventEmitter {
     * @arg {Boolean} [options.nsfw] The nsfw status of the channel (guild channels only)
     * @arg {String} [options.ownerID] The ID of the channel owner (group channels only)
     * @arg {String?} [options.parentID] The ID of the parent channel category for this channel (guild text/voice channels only)
+    * @arg {Array<Object>} [options.permissionOverwrites] An array containing permission overwrite objects
     * @arg {Number} [options.position] The sorting position of the channel (guild channels only)
     * @arg {Number} [options.rateLimitPerUser] The time in seconds a user has to wait before sending another message (does not affect bots or users with manageMessages/manageChannel permissions) (guild text and thread channels only)
     * @arg {String?} [options.rtcRegion] The RTC region ID of the channel (automatic if `null`) (guild voice channels only)
@@ -1279,7 +1280,8 @@ class Client extends EventEmitter {
             rtc_region: options.rtcRegion,
             topic: options.topic,
             user_limit: options.userLimit,
-            voice_quality_mode: options.voiceQualityMode,
+            video_quality_mode: options.videoQualityMode,
+            permission_overwrites: options.permissionOverwrites,
             reason: reason
         }).then((channel) => Channel.from(channel, this));
     }

diff --git a/lib/structures/GuildChannel.js b/lib/structures/GuildChannel.js
@@ -80,6 +80,7 @@ class GuildChannel extends Channel {
     * @arg {String} [options.name] The name of the channel
     * @arg {Boolean} [options.nsfw] The nsfw status of the channel
     * @arg {Number?} [options.parentID] The ID of the parent channel category for this channel (guild text/voice channels only) or the channel ID where the thread originated from (thread channels only)
+    * @arg {Array<Object>} [options.permissionOverwrites] An array containing permission overwrite objects
     * @arg {Number} [options.position] The sorting position of the channel
     * @arg {Number} [options.rateLimitPerUser] The time in seconds a user has to wait before sending another message (does not affect bots or users with manageMessages/manageChannel permissions) (guild text and thread channels only)
     * @arg {String?} [options.rtcRegion] The RTC region ID of the channel (automatic if `null`) (guild voice channels only)