Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug section to readme #65

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add debug section to readme #65

merged 2 commits into from
Jul 18, 2023

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Jul 18, 2023

#60

I didn't add the link as it's already present in the references.

@8ctopus
Copy link
Contributor Author

8ctopus commented Jul 18, 2023

One point up for discussion is that in my tests, the measurement protocol validation server is absolutely rubbish as event params are not taken into consideration. Your code does a way better job at detecting missing params.

@aawnu aawnu merged commit b236d27 into aawnu:master Jul 18, 2023
@8ctopus 8ctopus deleted the readme-debug branch July 18, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants