Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/migration npm deps to forge #382

Merged
merged 27 commits into from
Feb 20, 2024
Merged

Chore/migration npm deps to forge #382

merged 27 commits into from
Feb 20, 2024

Conversation

parth-15
Copy link
Contributor

No description provided.

@height Height
Copy link

height bot commented Jan 25, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parth-15 parth-15 force-pushed the chore/migration-npm-deps-to-forge branch from fb2f625 to 3b02601 Compare January 29, 2024 11:45
@parth-15 parth-15 force-pushed the chore/migration-npm-deps-to-forge branch from 3b02601 to 58cc954 Compare January 29, 2024 18:58
@miguelmtzinf miguelmtzinf mentioned this pull request Feb 20, 2024
Open
miguelmtzinf
miguelmtzinf reviewed Feb 20, 2024
View reviewed changes
package.json
"overrides": {
"@nomicfoundation/hardhat-toolbox": {
"@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers"
"@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@0.3.0-beta.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change is necessary? would prefer to avoid "beta" packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already using beta in existing implementation. I just highlighted it to make it more explicit. https://github.com/aave/gho-core/blob/main/package-lock.json#L11459-L11466

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as it is, given that there are compatibility issues between hardhat-deploy and hardhat-toolbox..,

@miguelmtzinf miguelmtzinf merged commit 3b6810c into main Feb 20, 2024
30 checks passed
@miguelmtzinf miguelmtzinf deleted the chore/migration-npm-deps-to-forge branch February 20, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

@PrinceRuler PrinceRuler PrinceRuler approved these changes

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parth-15 @miguelmtzinf @PrinceRuler