Fix: typos #715
Merged
Fix: typos #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Modify interface versions to support all minor 0.8.x vers
Make DefaultInterestRateStrategy contract inheritable
Fix: typos
omahs
requested review from
The-3D,
miguelmtzinf,
stevenvaleri,
foodaka,
kartojal,
Zer0dot,
donosonaumczuk and
BenSparksCode
as code owners
|
can we point this to the 3.0.1 branch? |
|
@The-3D Is it the correct branch now? aave:feat/3.0.1 |
kyzia551
reviewed
Nov 1, 2022
| function calculateInterestRates(DataTypes.CalculateInterestRatesParams calldata params) | ||
| external | ||
| function calculateInterestRates(DataTypes.CalculateInterestRatesParams memory params) | ||
| public |
There was a problem hiding this comment.
@miguelmtzinf is it needed?
There was a problem hiding this comment.
Github's diff is broken. These changes are already part of the codebase
miguelmtzinf
reviewed
Nov 3, 2022
This was referenced Jul 31, 2024
This was referenced Aug 6, 2024
This was referenced Aug 16, 2024
This was referenced Aug 24, 2024
This was referenced Sep 1, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: typos