Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent token events #210

Merged
merged 19 commits into from
Dec 3, 2021
Merged

fix: inconsistent token events #210

merged 19 commits into from
Dec 3, 2021

Conversation

stevenvaleri
Copy link
Contributor

No description provided.

@stevenvaleri stevenvaleri linked an issue Nov 11, 2021 that may be closed by this pull request
Inconsistent events when burning/minting ATokens, VariableDebtTokens and StableDebtTokens #179
Closed
@stevenvaleri stevenvaleri changed the title DRAFT fix: token events fix: inconsistent token events Nov 11, 2021
LHerskind
LHerskind reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me and make it more consistent. I'm not fully sold on the changes to Transfer, but get the sentiment.

miguelmtzinf
miguelmtzinf reviewed Dec 3, 2021
View reviewed changes
.npmrc Outdated Show resolved Hide resolved
@The-3D The-3D merged commit 8e236ec into master Dec 3, 2021
@The-3D The-3D deleted the feat/fix-token-events branch December 3, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind left review comments

@miguelmtzinf miguelmtzinf miguelmtzinf left review comments

@The-3D The-3D The-3D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent events when burning/minting ATokens, VariableDebtTokens and StableDebtTokens
4 participants
@stevenvaleri @LHerskind @miguelmtzinf @The-3D