feat: Add test cases

aave · Sep 21, 2021 · 0814ac2 · 0814ac2
1 parent 973e644
commit 0814ac2
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 4 deletions.
diff --git a/contracts/mocks/helpers/MockReserveConfiguration.sol b/contracts/mocks/helpers/MockReserveConfiguration.sol
@@ -111,6 +111,16 @@ contract MockReserveConfiguration {
     return configuration.getSupplyCap();
   }
 
+  function setUnbackedMintCap(uint256 unbackedMintCap) external {
+    DataTypes.ReserveConfigurationMap memory config = configuration;
+    config.setUnbackedMintCap(unbackedMintCap);
+    configuration = config;
+  }
+
+  function getUnbackedMintCap() external view returns (uint256) {
+    return configuration.getUnbackedMintCap();
+  }
+
   function getFlags()
     external
     view

diff --git a/helpers/constants.ts b/helpers/constants.ts
@@ -18,6 +18,7 @@ export const MAX_UINT_AMOUNT =
   '115792089237316195423570985008687907853269984665640564039457584007913129639935';
 export const MAX_BORROW_CAP = '68719476735';
 export const MAX_SUPPLY_CAP = '68719476735';
+export const MAX_UNBACKED_MINT_CAP = '68719476735';
 export const ONE_YEAR = '31536000';
 export const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';
 export const ONE_ADDRESS = '0x0000000000000000000000000000000000000001';

diff --git a/test-suites/configurator-edge.spec.ts b/test-suites/configurator-edge.spec.ts
@@ -2,7 +2,7 @@ import { expect } from 'chai';
 import { BigNumber } from 'ethers';
 import { makeSuite, TestEnv } from './helpers/make-suite';
 import { ProtocolErrors } from '../helpers/types';
-import { MAX_BORROW_CAP, MAX_UINT_AMOUNT } from '../helpers/constants';
+import { MAX_BORROW_CAP, MAX_UNBACKED_MINT_CAP, MAX_UINT_AMOUNT, MAX_SUPPLY_CAP } from '../helpers/constants';
 import { convertToCurrencyDecimals } from '../helpers/contracts-helpers';
 
 makeSuite('PoolConfigurator: Edge cases', (testEnv: TestEnv) => {
@@ -15,6 +15,7 @@ makeSuite('PoolConfigurator: Edge cases', (testEnv: TestEnv) => {
     PC_RESERVE_LIQUIDITY_NOT_0,
     RC_INVALID_BORROW_CAP,
     RC_INVALID_SUPPLY_CAP,
+    RC_INVALID_UNBACKED_MINT_CAP,
   } = ProtocolErrors;
 
   it('ReserveConfiguration setLiquidationBonus() threshold > MAX_VALID_LIQUIDATION_THRESHOLD', async () => {
@@ -139,10 +140,17 @@ makeSuite('PoolConfigurator: Edge cases', (testEnv: TestEnv) => {
   it('Tries to update supplyCap > MAX_SUPPLY_CAP (revert expected)', async () => {
     const { configurator, weth } = testEnv;
     await expect(
-      configurator.setSupplyCap(weth.address, BigNumber.from(MAX_BORROW_CAP).add(1))
+      configurator.setSupplyCap(weth.address, BigNumber.from(MAX_SUPPLY_CAP).add(1))
     ).to.be.revertedWith(RC_INVALID_SUPPLY_CAP);
   });
 
+  it('Tries to update unbackedMintCap > MAX_UNBACKED_MINT_CAP (revert expected)', async () => {
+    const { configurator, weth } = testEnv;
+    await expect(
+      configurator.setUnbackedMintCap(weth.address, BigNumber.from(MAX_UNBACKED_MINT_CAP).add(1))
+    ).to.be.revertedWith(RC_INVALID_UNBACKED_MINT_CAP);
+  });
+
   it('Tries to disable the DAI reserve with liquidity on it (revert expected)', async () => {
     const { dai, pool, configurator } = testEnv;
     const userAddress = await pool.signer.getAddress();

diff --git a/test-suites/configurator-liquidation-protocol-fee.spec.ts b/test-suites/configurator-liquidation-protocol-fee.spec.ts
@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 import { utils } from 'ethers';
-import { MAX_UINT_AMOUNT, MAX_SUPPLY_CAP } from '../helpers/constants';
-import { convertToCurrencyDecimals } from '../helpers/contracts-helpers';
+import { MAX_UINT_AMOUNT } from '../helpers/constants';
 import { ProtocolErrors } from '../helpers/types';
 import { TestEnv, makeSuite } from './helpers/make-suite';
 

diff --git a/test-suites/configurator.spec.ts b/test-suites/configurator.spec.ts
@@ -73,6 +73,8 @@ const getReserveData = async (helpersContract: AaveProtocolDataProvider, asset:
     helpersContract.getReserveConfigurationData(asset),
     helpersContract.getReserveCaps(asset),
     helpersContract.getPaused(asset),
+    helpersContract.getLiquidationProtocolFee(asset),
+    helpersContract.getUnbackedMintCap(asset),
   ]);
 };
 
@@ -454,6 +456,26 @@ makeSuite('PoolConfigurator', (testEnv: TestEnv) => {
     expect(isPaused).to.be.equal(false);
   });
 
+  it('Updates the unbackedMintCap of WETH via pool admin', async () => {
+    const { configurator, helpersContract, weth } = testEnv;
+    const newUnbackedMintCap = '10000';
+    expect(await configurator.setUnbackedMintCap(weth.address, newUnbackedMintCap))
+      .to.emit(configurator, 'UnbackedMintCapChanged')
+      .withArgs(weth.address, newUnbackedMintCap);
+
+    expect(await helpersContract.getUnbackedMintCap(weth.address)).to.be.eq(newUnbackedMintCap);
+  });
+
+  it('Updates the unbackedMintCap of WETH via risk admin', async () => {
+    const { configurator, helpersContract, weth } = testEnv;
+    const newUnbackedMintCap = '20000';
+    expect(await configurator.setUnbackedMintCap(weth.address, newUnbackedMintCap))
+      .to.emit(configurator, 'UnbackedMintCapChanged')
+      .withArgs(weth.address, newUnbackedMintCap);
+
+    expect(await helpersContract.getUnbackedMintCap(weth.address)).to.be.eq(newUnbackedMintCap);
+  });
+
   it('Updates the borrowCap of WETH via pool admin', async () => {
     const { configurator, helpersContract, weth } = testEnv;
     const newBorrowCap = '3000000';

diff --git a/test-suites/reserve-configuration.spec.ts b/test-suites/reserve-configuration.spec.ts
@@ -24,6 +24,7 @@ describe('ReserveConfiguration', async () => {
   const DECIMALS = BigNumber.from(18);
   const BORROW_CAP = BigNumber.from(100);
   const SUPPLY_CAP = BigNumber.from(200);
+  const UNBACKED_MINT_CAP = BigNumber.from(300);
 
   const MAX_VALID_LTV = BigNumber.from(65535);
   const MAX_VALID_LIQUIDATION_THRESHOLD = BigNumber.from(65535);
@@ -141,6 +142,14 @@ describe('ReserveConfiguration', async () => {
     expect(await configMock.getSupplyCap()).to.be.eq(ZERO);
   });
 
+  it('getUnbackedMintCap()', async () => {
+    expect(await configMock.getUnbackedMintCap()).to.be.eq(ZERO);
+    expect(await configMock.setUnbackedMintCap(UNBACKED_MINT_CAP));
+    expect(await configMock.getUnbackedMintCap()).to.be.eq(UNBACKED_MINT_CAP);
+    expect(await configMock.setUnbackedMintCap(ZERO));
+    expect(await configMock.getUnbackedMintCap()).to.be.eq(ZERO);
+  });
+
   it('setLtv() with ltv = MAX_VALID_LTV', async () => {
     expect(await configMock.getParams()).to.be.eql([ZERO, ZERO, ZERO, ZERO, ZERO]);
     expect(await configMock.getLtv()).to.be.eq(ZERO);