Attempt to fix EventReader limitations. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventReader was a wrapper over IParser that offered some abstractions for parsing, but also had some design flaws. It has been replaced by extension methods for IParser. The extension methods provide the same functionality, and allow to always use the same type to represent the parser.
|
Brilliant! Less wrapping is always good. And the breaking change is less visible as you use IParser all the way through. |
|
How/where do you usually document this breaking changes? If you do it at all. Let me know if I can help to get this merged asap. Tks. |
|
The breaking changes are documented in the release notes, and also expressed in the version number. In this case, the major version number will be incremented, signaling a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.