Added default maximum recursion level of 130 (max when using defaults on Windows/.net8)#1110
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1109 by adding a default maximum recursion limit to deserialization, preventing deeply nested YAML from causing an uncatchable StackOverflowException and terminating the process.
Changes:
- Set a default
maximumRecursionvalue inDeserializerBuilderso the default deserializer configuration enforces a recursion cap. - Added recursion-level seeding in
Deserializer.Deserialize(IParser, Type, int)and introduced an overload that uses a default value. - Added a unit test to verify a
MaximumRecursionLevelReachedExceptionis thrown for extremely deep nesting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
YamlDotNet/Serialization/DeserializerBuilder.cs |
Sets a default max recursion limit in the default deserializer builder configuration. |
YamlDotNet/Serialization/Deserializer.cs |
Adds a new overload/signature for Deserialize and seeds recursion state for limit enforcement. |
YamlDotNet.Test/Serialization/DeserializerTest.cs |
Adds a regression test covering default recursion limit behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 26, 2026
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1109