Add net9.0 and net10.0 target frameworks#1089
Closed
fdcastel wants to merge 1 commit intoaaubry:masterfrom
Closed
Conversation
Contributor
Author
|
AppVeyor's FixAdded a install:
- cmd: git submodule update --init
- ps: |
Invoke-WebRequest -Uri 'https://dot.net/v1/dotnet-install.ps1' -OutFile 'dotnet-install.ps1'
.\dotnet-install.ps1 -Channel 10.0 -InstallDir "$env:ProgramFiles\dotnet"
- cmd: |
dotnet tool install --global GitVersion.Tool --version 6.5.1
dotnet tool restore |
Add net9.0 and net10.0 to both the library and test project TargetFrameworks. Fix OrderedDictionary ambiguity for net9.0+: .NET 9 introduced System.Collections.Generic.OrderedDictionary<TKey, TValue> which conflicts with YamlDotNet.Helpers.OrderedDictionary<TKey, TValue>. Disambiguate by using fully qualified type names in YamlMappingNode.cs and OrderedDictionaryTests.cs. Update appveyor.yml to install the .NET 10 SDK and add artifact paths for the new target frameworks.
fdcastel
force-pushed
the
feature/add-net9-net10-targets
branch
from
2c1d6c2 to
b728f0f
Compare
Collaborator
|
This is fixed in #1092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
net9.0andnet10.0to theTargetFrameworkslist for both theYamlDotNetlibrary andYamlDotNet.Testprojects.Changes
New target frameworks
net10.0;net9.0;net8.0;net6.0;netstandard2.0;netstandard2.1;net47net10.0;net9.0;net8.0;net6.0;net47OrderedDictionary ambiguity fix
.NET 9 introduced
System.Collections.Generic.OrderedDictionary<TKey, TValue>, which conflicts withYamlDotNet.Helpers.OrderedDictionary<TKey, TValue>. This causedCS0104ambiguity errors when compiling for net9.0+.Fixed by using fully qualified type names:
YamlMappingNode.cs—Helpers.OrderedDictionary<YamlNode, YamlNode>OrderedDictionaryTests.cs—YamlDotNet.Helpers.OrderedDictionary<int, string>Files Changed
YamlDotNet/YamlDotNet.csprojYamlDotNet.Test/YamlDotNet.Test.csprojYamlDotNet/RepresentationModel/YamlMappingNode.csYamlDotNet.Test/Helpers/OrderedDictionaryTests.csTest Results