Fix infinite loop in source generator exception handler#1087
Merged
EdwardCooke merged 1 commit intoaaubry:masterfrom Apr 9, 2026
Merged
Fix infinite loop in source generator exception handler#1087EdwardCooke merged 1 commit intoaaubry:masterfrom
EdwardCooke merged 1 commit intoaaubry:masterfrom
Conversation
The catch block in TypeFactoryGenerator.GenerateSource() walked inner exceptions using variable 'e', but every iteration read from 'exception' (the outer variable) instead of 'e'. This produced an infinite loop that only ever printed the outermost message and never terminated. Replace 'exception' with 'e' inside the loop body for Message, StackTrace, and InnerException. Add tests validating the inner exception traversal pattern terminates correctly and captures all messages in the chain.
EdwardCooke
approved these changes
Apr 9, 2026
This was referenced Apr 9, 2026
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
catchblock inTypeFactoryGenerator.GenerateSource()walks inner exceptions using variablee, but every iteration reads fromexception(the outer variable) instead ofe. This produces an infinite loop that only ever prints the outermost message and never terminates.Fix
Replace
exceptionwitheinside the loop body forMessage,StackTrace, andInnerException.Tests Added
InnerExceptionTraversal_TerminatesAndCapturesAllMessages— 3-level exception chainInnerExceptionTraversal_SingleException_TerminatesAfterOne— single exceptionErrorCommentFormat_ContainsAllExceptionDetails— validates full output formatFiles Changed
YamlDotNet.Analyzers.StaticGenerator/TypeFactoryGenerator.csYamlDotNet.Test/Analyzers/StaticGenerator/TypeFactoryGeneratorTests.cs(new)