Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160: Write unit tests for SQLDatabaseUtils #172

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

aaronhktan
Copy link
Owner

Description

This commit adds unit tests that test version upgrade functionality, as well as dictionary import functionality.

Part of a series of commits for #160.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on all three platforms.

PASS	Executing test case TestSqlDatabaseUtils
	Qt version: 5.15.2
	Qt build: Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160406 (Red Hat 5.3.1-6))
	QTest version: 5.15.2
PASS	Executing test function initTestCase
PASS	TestSqlDatabaseUtils::initTestCase
	Execution took 0.259449 ms.
PASS	Executing test function updateDatabaseFromV1
PASS	TestSqlDatabaseUtils::updateDatabaseFromV1
	Execution took 49.8147 ms.
PASS	Executing test function updateDatabaseFromV2
PASS	TestSqlDatabaseUtils::updateDatabaseFromV2
	Execution took 44.7733 ms.
PASS	Executing test function addAndRemoveSources
PASS	TestSqlDatabaseUtils::addAndRemoveSources
	Execution took 53.7935 ms.
PASS	Executing test function readSources
PASS	TestSqlDatabaseUtils::readSources
	Execution took 33.3397 ms.
PASS	Executing test function cleanupTestCase
PASS	TestSqlDatabaseUtils::cleanupTestCase
	Execution took 0.001573 ms.
	Test execution took 182.273 ms.

Checklist:

  • My code follows the style guidelines of this project (black for Python
    code, .clang-format in the src/jyut-dict directory for C++)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have translated my user-facing strings to all currently-supported languages
  • I have made corresponding changes to the documentation

- These unit tests test the version upgrade functionality, as well
  as dictionary import functionality.
@aaronhktan aaronhktan added the maintenance Code quality, maintainability, tech debt label Mar 13, 2024
@aaronhktan aaronhktan added this to the 2024 Milestone 1 milestone Mar 13, 2024
@aaronhktan aaronhktan self-assigned this Mar 13, 2024
@aaronhktan aaronhktan merged commit fd1d850 into main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code quality, maintainability, tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant