Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Qt 6 #136

Open
aaronhktan opened this issue Sep 1, 2023 · 0 comments
Open

Move to Qt 6 #136

aaronhktan opened this issue Sep 1, 2023 · 0 comments
Assignees
@aaronhktan
Labels
enhancement Improvement to existing feature maintenance Code quality, maintainability, tech debt
Milestone
2024 Milestone 2

Comments

@aaronhktan
Copy link
Owner

Qt 5 is super outdated by now. This project should move to Qt 6 (there's already a branch that does that but it's fallen into disrepair).

This entails:

  • Moving from qmake to CMake since qmake is probably not long for this world
  • Dropping support for Windows 7 and 8
  • Deleting the various Qt5 checks in the codebase
@aaronhktan aaronhktan added enhancement Improvement to existing feature maintenance Code quality, maintainability, tech debt labels Sep 1, 2023
@aaronhktan aaronhktan added this to the 2023 Milestone 2 milestone Sep 1, 2023
@aaronhktan aaronhktan self-assigned this Sep 1, 2023
@aaronhktan aaronhktan removed the status in 2023 Milestone 2 Sep 1, 2023
@aaronhktan aaronhktan moved this to Todo in 2023 Milestone 2 Sep 1, 2023
@aaronhktan aaronhktan moved this from Todo to In Progress in 2024 Milestone 1 Jan 12, 2024
@aaronhktan aaronhktan mentioned this issue Mar 9, 2024
Merged
7 tasks
aaronhktan added a commit that referenced this issue Mar 9, 2024
@aaronhktan
#136: Move from qmake to CMake (#166)
83e44f0 
# Description

This commit switches the project's build system from qmake to CMake.

Using CMake has several advantages:
* Looking forward, Qt 6 uses CMake by default. It will be easier to
migrate to Qt 6 with CMake as the default build system.
* CMake is essentially an industry standard for C++ projects. This is a
good learning opportunity, and because there are many people using
CMake, it is easy to find resources for most edge-cases.
* Automatic discovery of tests whose build system is CMake-by-default.

Part of a series of commits for #136.

## Type of change

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] This change requires a documentation update

# How Has This Been Tested?

Tested by building debug builds on macOS, Windows, and Linux. Packaging
for release has not yet been tested, and will be tested once a release
is closer.

# Checklist:

- [x] My code follows the style guidelines of this project (`black` for
Python
  code, `.clang-format` in the `src/jyut-dict` directory for C++)
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have translated my user-facing strings to all
currently-supported languages
- [x] I have made corresponding changes to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronhktan aaronhktan

Labels
enhancement Improvement to existing feature maintenance Code quality, maintainability, tech debt
Projects
No open projects
2023 Milestone 2
Status: Todo
Milestone
2024 Milestone 2
Development

No branches or pull requests
1 participant
@aaronhktan