Optimize by caching webmention data into memory #105
Conversation
|
@nhoizey Will you be able to test your site against this branch to test if there are any performance improvements (without loss of existing renders from this plugin) in real-world sites..? |
|
Wow, that cut things in half with my test site. Will try on a local build of my site momentarily. |
|
On my site it cut build time from ~1000s to ~200s. What a huge difference from such a small change! |
| # | ||
| # Returns nothing. | ||
| def self.dump_yaml(file, data = {}) | ||
| @webmention_data_cache[file] = data | ||
| File.open(file, "wb") { |f| f.puts YAML.dump(data) } |
There was a problem hiding this comment.
Is there a way to async this operation so it doesn’t block?
There was a problem hiding this comment.
Which of the two operations is the blocker..?
Either ways, :dump_yaml is called just 3-4 times in a build, so it shouldn't cause any noticeable bottlenecks..
There was a problem hiding this comment.
I was figuring the disk write might do some blocking. But maybe it doesn’t.
Results in massive performance gains by bypassing repeated parsing of YAML files 🎉