Skip to content

Laravel 12.x Compatibility#156

Merged
aarondfrancis merged 2 commits intoaarondfrancis:mainfrom
laravel-shift:l12-compatibility
May 7, 2025
Merged

Laravel 12.x Compatibility#156
aarondfrancis merged 2 commits intoaarondfrancis:mainfrom
laravel-shift:l12-compatibility

Conversation

@laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.

Before merging, you need to:

  • Checkout the l12-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 12. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/sidecar.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "hammerstone/sidecar": "dev-l12-compatibility",
    }
}

Finally, run: composer update

@stefanzweifel
Copy link
Contributor

@aarondfrancis Any chance you get time to merge this PR and create a new release? Thanks a ton!

@adrorocker
Copy link

Hello there @aarondfrancis

Thanks for the awesome work on this package. I wonder if you would have any time to look into this PR and potentially merge it.

We cannot upgrade one of our projects to L12 due to the constraint on the awesome package @stefanzweifel created.

Thanks in advance.

@juliancc
Copy link

Any way we can help to get this merged?

@matter3
Copy link

matter3 commented Apr 17, 2025

Is there anything blocking this from being merged? We would highly appreciate it if you have a moment 🫶

@stefanzweifel
Copy link
Contributor

I've pinged Aaron through his private Slack community. He will take a look.
This week he's at React Miami, so might take another day or two.

@connecteev
Copy link

@aarondfrancis thank you in advance for merging this in to support laravel 12!

@guiassemany
Copy link

Hey @stefanzweifel and @aarondfrancis!

First of all, thank you for such an amazing work!

Do you have any news about this merge?

Thank you!

@stefanzweifel
Copy link
Contributor

No update from me; I'm not a maintainer on the repo. I hope @aarondfrancis finds some time in the next few days to review/merge this PR.

@aarondfrancis aarondfrancis merged commit 52e8582 into aarondfrancis:main May 7, 2025
@aarondfrancis
Copy link
Owner

It is with great shame I am pleased to announced the PR has been merged 🎉 🎉 🎉

@connecteev
Copy link

@aarondfrancis when I try to replace the fork: https://github.com/near-u/sidecar with hammerstone/sidecar, I still get this error. It looks like the branch has to be merged and a release has to be made for it to work.

diff --git a/composer.json b/composer.json
index b82bab96..b3066c9b 100644
--- a/composer.json
+++ b/composer.json
@@ -11,7 +11,7 @@
         "dompdf/dompdf": "^3.0",
         "gliterd/laravel-backblaze-b2": "dev-main",
         "guzzlehttp/guzzle": "^7.8",
-        "hammerstone/sidecar": "dev-main",
+        "hammerstone/sidecar": "^0.6.1",
         "http-interop/http-factory-guzzle": "^1.2",
         "inertiajs/inertia-laravel": "^2.0",
         "io-developer/php-whois": "^4.1",
@@ -113,10 +113,6 @@
         {
             "type": "path",
             "url": "_LOCAL_PACKAGES/gliterd_backblaze_b2_package"
-        },
-        {
-            "type": "vcs",
-            "url": "https://github.com/near-u/sidecar"
         }
     ],
composer install
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires hammerstone/sidecar ^0.6.1 -> satisfiable by hammerstone/sidecar[v0.6.1].
    - Root composer.json requires inertiajs/inertia-laravel ^2.0 -> satisfiable by inertiajs/inertia-laravel[v2.0.0, v2.0.1, v2.0.2].
    - Root composer.json requires laravel/sanctum ^4.0 -> satisfiable by laravel/sanctum[v4.0.0, ..., v4.1.1].
    - hammerstone/sidecar v0.6.1 requires illuminate/console ^8|^9|^10|^11 -> satisfiable by illuminate/console[v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16, v10.0.0, ..., v10.48.28, v11.0.0, ..., v11.44.7].
    - illuminate/console[v10.0.0, ..., v10.16.1] require symfony/console ^6.2 -> satisfiable by symfony/console[v6.2.0, ..., v6.4.21].
    - illuminate/console[v10.17.0, ..., v10.25.0] require laravel/prompts ^0.1 -> found laravel/prompts[v0.1.0, ..., v0.1.25] but it conflicts with your root composer.json require (^0.3.2).
    - illuminate/console[v10.33.0, ..., v10.48.28] require laravel/prompts ^0.1.9 -> found laravel/prompts[v0.1.9, ..., v0.1.25] but it conflicts with your root composer.json require (^0.3.2).
    - illuminate/console[v11.16.0, ..., v11.23.5] require laravel/prompts ^0.1.12 -> found laravel/prompts[v0.1.12, ..., v0.1.25] but it conflicts with your root composer.json require (^0.3.2).
    - illuminate/console[v11.24.0, ..., v11.27.2] require laravel/prompts ^0.1.18|^0.2.0 -> found laravel/prompts[v0.1.18, ..., v0.2.1] but it conflicts with your root composer.json require (^0.3.2).
    - illuminate/console[v11.28.0, ..., v11.44.7] require illuminate/contracts ^11.0 -> satisfiable by illuminate/contracts[v11.0.0, ..., v11.44.7].
    - laravel/sanctum[v4.0.0, ..., v4.0.7] require illuminate/contracts ^11.0 -> satisfiable by illuminate/contracts[v11.0.0, ..., v11.44.7].
    - illuminate/console[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.4.6) does not satisfy that requirement.
    - illuminate/console[v8.12.0, ..., v8.18.0] require symfony/console ^5.1 -> satisfiable by symfony/console[v5.1.0, ..., v5.4.47].
    - illuminate/console[v8.18.1, ..., v8.73.2] require symfony/console ^5.1.4 -> satisfiable by symfony/console[v5.1.4, ..., v5.4.47].
    - illuminate/console[v8.74.0, ..., v8.83.27] require symfony/console ^5.4 -> satisfiable by symfony/console[v5.4.0, ..., v5.4.47].
    - illuminate/console[v9.0.0, ..., v9.34.0] require symfony/console ^6.0 -> satisfiable by symfony/console[v6.0.0, ..., v6.4.21].
    - illuminate/console[v9.45.0, ..., v9.52.16] require symfony/console ^6.0.9 -> satisfiable by symfony/console[v6.0.9, ..., v6.4.21].
    - laravel/sanctum[v4.0.8, ..., v4.1.1] require symfony/console ^7.0 -> satisfiable by symfony/console[v7.0.0, ..., v7.2.6].
    - Conclusion: don't install illuminate/contracts v11.44.7 (conflict analysis result)
    - You can only install one version of a package, so only one of these can be installed: symfony/console[v2.5.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.49, v5.0.0, ..., v5.4.47, v6.0.0, ..., v6.4.21, v7.0.0, ..., v7.2.6].
    ```

@aarondfrancis
Copy link
Owner

yeah I just cut a new release

@stefanzweifel
Copy link
Contributor

@aarondfrancis Thank you, Aaron. ❤️

@connecteev
Copy link

thank you @aarondfrancis!

@cmanish049
Copy link

thank you @aarondfrancis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants