Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in event handlers #47

Open
luithefirst opened this issue Apr 26, 2023 · 0 comments
Open

Memory leak in event handlers #47

luithefirst opened this issue Apr 26, 2023 · 0 comments

Comments

@luithefirst
Copy link
Member

Here is a minimal example:
https://github.com/aardvark-platform/aardvark.media/blob/main/src/Scratch/29%20-%20Garbage%20Collection/App.fs

The onClick handler closure holds temporary data that is then pinned at this line forever:

aardvark.media/src/Aardvark.UI/Updater.fs

Line 297 in b197d1b

state.handlers.[key] <- evt.serverSide

luithefirst added a commit that referenced this issue Apr 27, 2023
@luithefirst
proper registration and cleanup of event handlers (#47)
1824b79
luithefirst added a commit that referenced this issue Apr 27, 2023
@luithefirst
reworked event handler management (#47)
e3c5082
luithefirst added a commit that referenced this issue Apr 27, 2023
@luithefirst
proper registration and cleanup of event handlers (#47)
c7ca492 
# Conflicts:
#	src/Aardvark.UI/Updater.fs
luithefirst added a commit that referenced this issue Apr 27, 2023
@luithefirst
reworked event handler management (#47)
57a04e5 
# Conflicts:
#	src/Aardvark.UI/Updater.fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luithefirst